From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19359-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 22419 invoked by alias); 11 Oct 2002 07:08:32 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 22331 invoked from network); 11 Oct 2002 07:08:30 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 11 Oct 2002 07:08:30 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9B6mTX25916
	for <gdb-patches@sources.redhat.com>; Fri, 11 Oct 2002 02:48:29 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9B78Tf16564
	for <gdb-patches@sources.redhat.com>; Fri, 11 Oct 2002 03:08:29 -0400
Received: from localhost.localdomain (vpn50-21.rdu.redhat.com [172.16.50.21])
	by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9B78Ta15350;
	Fri, 11 Oct 2002 03:08:29 -0400
Received: (from kev@localhost)
	by localhost.localdomain (8.11.6/8.11.6) id g9B6ukI14914;
	Thu, 10 Oct 2002 23:56:46 -0700
Date: Fri, 11 Oct 2002 00:08:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1021011065646.ZM14913@localhost.localdomain>
In-Reply-To: "Martin M. Hunt" <hunt@redhat.com>
        "Re: [RFA] string_to_core_addr fix" (Oct 10,  9:29pm)
References: <200210101507.46548.hunt@redhat.com> 
	<1021010223959.ZM14496@localhost.localdomain> 
	<200210102129.52218.hunt@redhat.com>
To: "Martin M. Hunt" <hunt@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] string_to_core_addr fix
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-10/txt/msg00231.txt.bz2

On Oct 10,  9:29pm, Martin M. Hunt wrote:

> For years we used parse_and_eval_address() in Insight until earlier this year 
> when those calls were replaced with string_to_core_addr(), breaking all mips 
> targets.  parse_and_eval_address() internally calls INTEGER_TO_ADDRESS() so I 
> probably should use that. In fact I decided to just do what 
> parse_and_eval_address() did but apparently submitted the wrong version.
> 
> Revised patch attached.
> 
> Index: utils.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/utils.c,v
> retrieving revision 1.80
> diff -u -p -r1.80 utils.c
> --- utils.c	20 Sep 2002 00:24:01 -0000	1.80
> +++ utils.c	11 Oct 2002 04:29:51 -0000
> @@ -2649,6 +2649,8 @@ string_to_core_addr (const char *my_stri
>  	    internal_error (__FILE__, __LINE__, "invalid decimal");
>  	}
>      }
> +  if (INTEGER_TO_ADDRESS_P ())
> +    addr = INTEGER_TO_ADDRESS (builtin_type_void_data_ptr, &addr); 
>    return addr;
>  }

Okay, this version looks reasonable.  (Approved.)  Make sure you
update the ChangeLog entry to match.

Kevin