Re: [PATCH RFC] Character set support

Andrew Cagney
2002-09-20T16:08:18Z

> On Sep 19, 9:12pm, Andrew Cagney wrote:
>
>
>> 2002-09-09 Elena Zannoni <ezannoni@redhat.com>
>>
>> From: Emmanuel Thome' <thome@lix.polytechnique.fr>
>> * top.c (init_main): Set rl_terminal_name.
>>
>> to reflect both who committed and who created the change.
>
>
> Yes, I do it that way too from time to time usually for smaller
> changes that I might have to adapt somewhat. Jim's work is much more
> substantial and only minor changes were required. I felt that Jim's
> name should be prominent in the ChangeLog for this change.

In the above, Emmanuel's name is very prominant. It was their patch
that was committed.

The place to give credit for a work is either the top of a new file,
and/or in the doco. Suggest updating the (C) entry to include:

Contributed by Red Hat, Inc.
Written by Jim Blandy.

10 years from now, people won't be looking in the ChangeLog.

> If you really need to know who committed a change, the CVS logs and
> mailing list traffic are available. Also, I believe there is ample
> precedent in other projects (e.g. gcc) for the way I did things.

The accepted GDB convention is per the above. It means that the
ChangeLog stands on its own and does not depend on access to either the
CVS repository or the mailing lists. It leaves no confusion over who
committed and who authored the change.

>> Did the WCHAR problem get resolved?
>
>
> Yes, in the sense that we're taking Jim's patch as-is and we'll
> worry about wchar_t changes at some later date.
>
> See http://sources.redhat.com/ml/gdb-patches/2002-09/msg00261.html

Can you please at least create a bug report ``some later date'' work can
be tracked?

Andrew