From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-18118-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 5507 invoked by alias); 26 Aug 2002 21:22:43 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 5499 invoked from network); 26 Aug 2002 21:22:42 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 26 Aug 2002 21:22:42 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g7QL7ml06053
	for <gdb-patches@sources.redhat.com>; Mon, 26 Aug 2002 17:07:48 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g7QLMdu16018;
	Mon, 26 Aug 2002 17:22:39 -0400
Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g7QLMbe09880;
	Mon, 26 Aug 2002 14:22:38 -0700
Received: (from kev@localhost)
	by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g7QLMUZ32375;
	Mon, 26 Aug 2002 14:22:30 -0700
Date: Mon, 26 Aug 2002 15:31:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020826212230.ZM32374@localhost.localdomain>
In-Reply-To: Don Howard <dhoward@redhat.com>
        "Re: [RFA] GDB/622 - clear current breakpoint in commands causes trouble" (Aug 23, 10:48am)
References: <Pine.LNX.4.33.0208221506430.11494-100000@theotherone.redhat-remotie.org>
To: Don Howard <dhoward@redhat.com>, Michael Snyder <msnyder@redhat.com>
Subject: Re: [RFA] GDB/622 - clear current breakpoint in commands causes trouble
Cc: Joel Brobecker <brobecker@gnat.com>, <gdb-patches@sources.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-08/txt/msg00868.txt.bz2

On Aug 23, 10:48am, Don Howard wrote:

> One question: is it important to use xstrdup() over
> plain strdup()?

Don is right, xstrdup() should be used instead of strdup().  If there's
some good reason to prefer strdup(), then the return value needs to
be checked.  (Joel's 2002-07-31 patch isn't doing this.)

Kevin