From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17887-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 28791 invoked by alias); 20 Aug 2002 23:31:52 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 28784 invoked from network); 20 Aug 2002 23:31:51 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 20 Aug 2002 23:31:51 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g7KNHWl15673
	for <gdb-patches@sources.redhat.com>; Tue, 20 Aug 2002 19:17:32 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g7KNVlu01641;
	Tue, 20 Aug 2002 19:31:47 -0400
Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g7KNVke10962;
	Tue, 20 Aug 2002 16:31:46 -0700
Received: (from kev@localhost)
	by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g7KNVjI15651;
	Tue, 20 Aug 2002 16:31:45 -0700
Date: Tue, 20 Aug 2002 16:31:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020820233145.ZM15650@localhost.localdomain>
In-Reply-To: Elena Zannoni <ezannoni@redhat.com>
        "[RFA] rs6000-tdep.c: figure out e500 machine from bfd." (Aug 20,  6:36pm)
References: <15714.50288.526139.379896@localhost.redhat.com>
To: Elena Zannoni <ezannoni@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] rs6000-tdep.c: figure out e500 machine from bfd.
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-08/txt/msg00637.txt.bz2

On Aug 20,  6:36pm, Elena Zannoni wrote:

> +  /* For e500 executables, the apuinfo section is of help here.  */
> +  if (info.abfd)
> +    {
> +      sect = bfd_get_section_by_name (info.abfd, ".PPC.EMB.apuinfo");
> +      if (sect)

What is the apuinfo section?  If you know what it's about (I sure
don't), consider expanding the comment somewhat.

Is there any chance that this section could appear in non-e500
executables?  If so, make a note of this gotcha in the comment too.

Otherwise, fine.  Go ahead and commit it after expanding the comment
as necessary.

Kevin