From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30173 invoked by alias); 20 Aug 2002 20:57:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30166 invoked from network); 20 Aug 2002 20:57:49 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 20 Aug 2002 20:57:49 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g7KKhVl15798 for ; Tue, 20 Aug 2002 16:43:31 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g7KKvku00579; Tue, 20 Aug 2002 16:57:46 -0400 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g7KKvje06900; Tue, 20 Aug 2002 13:57:45 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g7KKvho26088; Tue, 20 Aug 2002 13:57:43 -0700 Date: Tue, 20 Aug 2002 13:57:00 -0000 From: Kevin Buettner Message-Id: <1020820205743.ZM26087@localhost.localdomain> In-Reply-To: Elena Zannoni "[RFA] rs6000-tdep.c: initial support for e500" (Aug 20, 4:16pm) References: <15714.41895.463071.288818@localhost.redhat.com> To: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] rs6000-tdep.c: initial support for e500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-08/txt/msg00616.txt.bz2 On Aug 20, 4:16pm, Elena Zannoni wrote: > This patch adds the initial machinery for supporting the Motorola e500 > processor. > > I added registers and pseudo registers in this patch. > I will follow up with abi changes soon. > > The e500 processor has vector registers which are 64 bit long. The > lower 32 bits of such registers are the same as the general registers > (hence the pseudos). No floating point registers in this processor. > > Elena > > 2002-08-19 Elena Zannoni > > * ppc-tdep.h (struct gdbarch_tdep): Add ev registers. > > * rs6000-tdep.c (rs6000_register_virtual_type): Return 64 bit > vector type for ev registers. > (e500_pseudo_register_read): New function. > (e500_pseudo_register_write): New function. > (e500_dwarf2_reg_to_regnum): New function. > (PPC_UISA_NOFP_SPRS): New macro. > (PPC_EV_REGS): New macro. > (PPC_GPRS_PSEUDO_REGS): New macro. > (registers_e500): New register set for e500. > (variants): Add e500 variant. > (rs6000_gdbarch_init): Move setting of pc, sp, fp regnums to > before setting architectural dependent variations. Initialize ev > registers numbers. Add case for e500 architecture. Set the > number of pseudo registers. Okay. The fact that the register numbers are so wildly different from any existing PPC port bothers me a bit, but I'll get over it. (Actually, the fact that they can vary as they did is a pretty good indicator that we've gotten things right elsewhere. I wonder though if there might not be a few places which still assume that gpr0 is 0 and gpr31 is 31. Hmm... yes, rs6000-nat.c has some code like this.) If I understand things correctly, the pseudo register numbers aren't set in stone, right? E.g, if there should come a day when we discover that some other register ought to be added, we could add it between the existing "real" registers and the pseudos, right? Before checking your patch in, take a look at the comments you added and make sure you have two spaces after each period. Also make sure that comments which contain sentences have periods at the ends. Kevin