From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17717-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 18043 invoked by alias); 16 Aug 2002 22:50:24 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 18036 invoked from network); 16 Aug 2002 22:50:23 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 16 Aug 2002 22:50:23 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g7GMaNl13176
	for <gdb-patches@sources.redhat.com>; Fri, 16 Aug 2002 18:36:23 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g7GMo5u04132;
	Fri, 16 Aug 2002 18:50:05 -0400
Received: from romulus.sfbay.redhat.com (IDENT:YRogGBqpDBWCqf59SX2LkJMa5UUnUsBq@romulus.sfbay.redhat.com [172.16.27.251])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g7GMo3e29145;
	Fri, 16 Aug 2002 15:50:04 -0700
Received: (from kev@localhost)
	by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g7GMo0l32198;
	Fri, 16 Aug 2002 15:50:00 -0700
Date: Fri, 16 Aug 2002 15:50:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020816225000.ZM32197@localhost.localdomain>
In-Reply-To: william@nscs.fast.net
        "Re: ChangeLog entry, re: gdb-5.2 and SCO OpenServer 5.0.5" (Aug 16,  6:18pm)
References: <200208161749.aa10539@mip486.nscs.fast.net> 
	<1020816220813.ZM31901@localhost.localdomain> 
	<200208161818.aa10685@mip486.nscs.fast.net>
To: william@nscs.fast.net, kevinb@redhat.com
Subject: Re: ChangeLog entry, re: gdb-5.2 and SCO OpenServer 5.0.5
Cc: ac131313@ges.redhat.com, gdb-patches@sources.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-08/txt/msg00467.txt.bz2

On Aug 16,  6:18pm, william@nscs.fast.net wrote:

> How is this:
> 
> 2002-08-16  William Bader  <william@nscs.fast.net>
> 
> 	* gdb/i386-tdep.c: Dynamically allocate buf;
> 	TARGET_PTR_BIT is not a constant.
> 
> --- gdb-5.2/gdb/i386-tdep.c-	Tue Feb 19 13:42:27 2002
> +++ gdb-5.2/gdb/i386-tdep.c	Fri Aug 16 18:13:00 2002
> @@ -858,7 +858,7 @@
>  int
>  get_longjmp_target (CORE_ADDR *pc)
>  {
> -  char buf[TARGET_PTR_BIT / TARGET_CHAR_BIT];
> +  char *buf = alloca (TARGET_PTR_BIT / TARGET_CHAR_BIT);
>    CORE_ADDR sp, jb_addr;
>  
>    sp = read_register (SP_REGNUM);

The patch looks good.  If it were me doing the ChangeLog entry,
I'd probably do it something like this:

	* i386-tdep.c (get_longjmp_target): Dynamically allocate ``buf''
	since TARGET_PTR_BIT is not a constant.

Or perhaps just:

	* i386-tdep.c (get_longjmp_target): Dynamically allocate ``buf''.

I just took a look at the current development sources and it looks to
me like this patch won't apply cleanly.  FWIW, the current development
sources don't use TARGET_PTR_BIT anymore (in the ``buf'' declaration)
so we're probably okay.

Kevin