From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27233 invoked by alias); 9 Aug 2002 00:55:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27226 invoked from network); 9 Aug 2002 00:55:10 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 9 Aug 2002 00:55:10 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g790fwl27338 for ; Thu, 8 Aug 2002 20:41:58 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g790t9u00906 for ; Thu, 8 Aug 2002 20:55:09 -0400 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g790t8e13412 for ; Thu, 8 Aug 2002 17:55:08 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g790t6h26694 for gdb-patches@sources.redhat.com; Thu, 8 Aug 2002 17:55:06 -0700 Date: Thu, 08 Aug 2002 17:55:00 -0000 From: Kevin Buettner Message-Id: <1020809005506.ZM26693@localhost.localdomain> To: gdb-patches@sources.redhat.com Subject: [PATCH] Avoid floatformat_from_doublest() assertion failure MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-08/txt/msg00199.txt.bz2 I've just committed the change below. On Irix, I was running into an assertion failure in floatformat_from_doublest() due to fmt being NULL. (gdb can't handle 16 byte long doubles.) The caller was store_floating() and, prior to the call, had determined that fmt was NULL and had printed a suitable warning. Moreover, the return value had been filled in with a suitable value. (Well, as suitable as possible for something that gdb says it can't do.) * doublest.c (store_floating): Avoid floatformat_from_doublest() assertion failure by returning early after a warning. Index: doublest.c =================================================================== RCS file: /cvs/src/src/gdb/doublest.c,v retrieving revision 1.9 diff -u -p -r1.9 doublest.c --- doublest.c 9 Feb 2002 17:25:57 -0000 1.9 +++ doublest.c 9 Aug 2002 00:37:23 -0000 @@ -681,6 +681,7 @@ store_floating (void *addr, int len, DOU { warning ("Can't store a floating-point number of %d bytes.", len); memset (addr, 0, len); + return; } floatformat_from_doublest (fmt, &val, addr);