From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Revise assertion in frame_saved_regs_register_unwind()
Date: Thu, 08 Aug 2002 14:06:00 -0000 [thread overview]
Message-ID: <1020808210553.ZM24863@localhost.localdomain> (raw)
In the course of rewriting mips_get_saved_register(), I found that
that an assertion in blockframe.c was erroneously failing. See
comment in patch for details. Also, note that set_unwind_by_pc()
sets the unwinder to frame_saved_regs_register_unwind() for the
non-generic dummy frame case.
(This patch is a prerequisite for my upcoming mips_get_saved_register()
rewrite.)
Okay to commit?
* blockframe.c (frame_saved_regs_register_unwind): Revise
PC_IN_CALL_DUMMY_ASSERTION to only apply when generic dummy
frames are in use.
Index: blockframe.c
===================================================================
RCS file: /cvs/src/src/gdb/blockframe.c,v
retrieving revision 1.34
diff -u -p -r1.34 blockframe.c
--- blockframe.c 24 Jul 2002 14:38:55 -0000 1.34
+++ blockframe.c 8 Aug 2002 20:54:14 -0000
@@ -1410,7 +1410,11 @@ frame_saved_regs_register_unwind (struct
/* There is always a frame at this point. And THIS is the frame
we're interested in. */
gdb_assert (frame != NULL);
- gdb_assert (!PC_IN_CALL_DUMMY (frame->pc, frame->frame, frame->frame));
+ /* If we're using generic dummy frames, we'd better not be in a call
+ dummy. (generic_call_dummy_register_unwind ought to have been called
+ instead.) */
+ gdb_assert (!(USE_GENERIC_DUMMY_FRAMES
+ && PC_IN_CALL_DUMMY (frame->pc, frame->frame, frame->frame)));
/* Load the saved_regs register cache. */
if (frame->saved_regs == NULL)
next reply other threads:[~2002-08-08 21:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-08 14:06 Kevin Buettner [this message]
2002-08-09 8:27 ` Andrew Cagney
2002-08-09 11:29 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020808210553.ZM24863@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox