From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17395-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 16311 invoked by alias); 6 Aug 2002 22:46:56 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 16298 invoked from network); 6 Aug 2002 22:46:56 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 6 Aug 2002 22:46:56 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g76MXvl05794
	for <gdb-patches@sources.redhat.com>; Tue, 6 Aug 2002 18:33:57 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g76Mkqu15783;
	Tue, 6 Aug 2002 18:46:52 -0400
Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g76Mkpe22117;
	Tue, 6 Aug 2002 15:46:51 -0700
Received: (from kev@localhost)
	by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g76Mko132175;
	Tue, 6 Aug 2002 15:46:50 -0700
Date: Tue, 06 Aug 2002 15:46:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020806224649.ZM32174@localhost.localdomain>
In-Reply-To: Andrew Cagney <ac131313@ges.redhat.com>
        "Re: [rfa/testsuite] One pass/fail per expect list" (Aug  5, 11:56pm)
References: <3D0A4801.8030001@cygnus.com> 
	<1020805225525.ZM26569@localhost.localdomain> 
	<3D4F48FA.1040108@ges.redhat.com>
To: Andrew Cagney <ac131313@ges.redhat.com>
Subject: Re: [rfa/testsuite] One pass/fail per expect list
Cc: Andrew Cagney <ac131313@cygnus.com>, gdb-patches@sources.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-08/txt/msg00145.txt.bz2

On Aug 5, 11:56pm, Andrew Cagney wrote:

> >> The attached tweaks gdb_expect_list{} so that it only prints one pass / 
> >> fail / ... message for the testcase.
> >> 
> >> What are peoples thoughts on this change and if positive, is the patch ok?
> > 
> > Now that it's in and I've had a chance to use it, the only part that
> > I don't like is:
> > 
> > 
> >> -		unresolved "${test}, pattern ${index} + sentinel"
> >> +		# unresolved "${test}, pattern ${index} + sentinel"
> > 
> > 
> > I found it useful to see the (potentially long list of) UNRESOLVED
> > messages after the FAIL so that I knew how many other parts of the
> > test hadn't been checked.
> 
> 
> What about including the total number of patterns in the test result 
> message vis:
> 	.... (pattern N of NN)

In the FAIL message, right?  If so, I think that'd be okay.

Kevin