From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5804 invoked by alias); 1 Aug 2002 22:18:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5795 invoked from network); 1 Aug 2002 22:18:13 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 1 Aug 2002 22:18:13 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g71M5gl00788 for ; Thu, 1 Aug 2002 18:05:42 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g71MIBu10836; Thu, 1 Aug 2002 18:18:11 -0400 Received: from romulus.sfbay.redhat.com (IDENT:jEJ6Je93t58GMrXq87gu+gDlY9Q7G+XI@romulus.sfbay.redhat.com [172.16.27.251]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g71MI9m08495; Thu, 1 Aug 2002 15:18:09 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g71MI7r30184; Thu, 1 Aug 2002 15:18:07 -0700 Date: Thu, 01 Aug 2002 15:18:00 -0000 From: Kevin Buettner Message-Id: <1020801221807.ZM30183@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit" (Aug 1, 5:55pm) References: <1020731210452.ZM23445@localhost.localdomain> <3D486843.8007D610@redhat.com> <1020731232203.ZM24308@localhost.localdomain> <3D4870EB.BB9C282A@redhat.com> <1020801011054.ZM24816@localhost.localdomain> <3D49AE69.3040708@ges.redhat.com> To: Andrew Cagney , Kevin Buettner , Michael Snyder Subject: Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-08/txt/msg00029.txt.bz2 On Aug 1, 5:55pm, Andrew Cagney wrote: > /* A non-floating-point argument being passed in a > general register. If a struct or union, and if > the remaining length is smaller than the register > size, we have to adjust the register value on > big endian targets. > > It does not seem to be necessary to do the > same for integral types. > > Also don't do this adjustment on EABI and O64 > binaries. > > cagney/2001-07-23: gdb/179: Also, GCC, when > outputting LE O32 with sizeof (struct) < > MIPS_SAVED_REGSIZE, generates a left shift as > part of storing the argument in a register a > register (the left shift isn't generated when > sizeof (struct) >= MIPS_SAVED_REGSIZE). Since it > is quite possible that this is GCC contradicting > the LE/O32 ABI, GDB has not been adjusted to > accommodate this. Either someone needs to > demonstrate that the LE/O32 ABI specifies such a > left shift OR this new ABI gets identified as > such and GDB gets tweaked accordingly. */ > > Sounds like the comment should be updated to mention a few more ABIs and > confirm that it is GCC that is wrong. I'll assume this patch is withdrawn. It is for the moment. If you read further in the thread, you'll see that I've verified that it's gcc which is wrong. That being the case, more than just the comment will need to change. (IMO, of course.) I'll wait a bit for further discussion before submitting a new patch. Kevin