Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [PATCH] mips-tdep.c: Add/update comments
Date: Thu, 01 Aug 2002 14:38:00 -0000	[thread overview]
Message-ID: <1020801213814.ZM29881@localhost.localdomain> (raw)

	* mips-tdep.c (mips_gdbarch_init): Add comments.  Fix typo in
	comment.

Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.86
diff -u -p -r1.86 mips-tdep.c
--- mips-tdep.c	1 Aug 2002 19:57:40 -0000	1.86
+++ mips-tdep.c	1 Aug 2002 21:34:20 -0000
@@ -4371,7 +4371,7 @@ mips_gdbarch_init (struct gdbarch_info i
   if (info.abfd == NULL && arches != NULL)
     mips_abi = gdbarch_tdep (arches->gdbarch)->found_abi;
 
-  /* Try the architecture for any hint of the corect ABI */
+  /* Try the architecture for any hint of the correct ABI.  */
   if (mips_abi == MIPS_ABI_UNKNOWN
       && info.bfd_arch_info != NULL
       && info.bfd_arch_info->arch == bfd_arch_mips)
@@ -4387,6 +4387,9 @@ mips_gdbarch_init (struct gdbarch_info i
 	  break;
 	case bfd_mach_mips8000:
 	case bfd_mach_mips10000:
+	  /* On Irix, ELF64 executables use the N64 ABI.  The
+	     pseudo-sections which describe the ABI aren't present
+	     on IRIX.  (Even for executables created by gcc.)  */
 	  if (bfd_get_flavour (info.abfd) == bfd_target_elf_flavour
 	      && elf_elfheader (info.abfd)->e_ident[EI_CLASS] == ELFCLASS64)
 	    mips_abi = MIPS_ABI_N64;
@@ -4665,6 +4668,8 @@ mips_gdbarch_init (struct gdbarch_info i
   set_gdbarch_address_to_pointer (gdbarch, address_to_signed_pointer);
   set_gdbarch_integer_to_address (gdbarch, mips_integer_to_address);
 
+  /* There are MIPS targets which do not yet use this since they still
+     define REGISTER_VIRTUAL_TYPE.  */
   set_gdbarch_register_virtual_type (gdbarch, mips_register_virtual_type);
 
   /* Hook in OS ABI-specific overrides, if they have been registered.  */


                 reply	other threads:[~2002-08-01 21:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1020801213814.ZM29881@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox