From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21227 invoked by alias); 1 Aug 2002 19:13:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21152 invoked from network); 1 Aug 2002 19:13:48 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 1 Aug 2002 19:13:48 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g71J1Il13507 for ; Thu, 1 Aug 2002 15:01:18 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g71JDfu09565; Thu, 1 Aug 2002 15:13:41 -0400 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g71JDem07448; Thu, 1 Aug 2002 12:13:40 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g71JDa928540; Thu, 1 Aug 2002 12:13:36 -0700 Date: Thu, 01 Aug 2002 12:13:00 -0000 From: Kevin Buettner Message-Id: <1020801191336.ZM28539@localhost.localdomain> In-Reply-To: Daniel Jacobowitz "Re: [PATCH] mips n64 support, part 1" (Aug 1, 3:06pm) References: <1020731182328.ZM22007@localhost.localdomain> <3D4985BA.1080308@ges.redhat.com> <20020801190652.GA13050@nevyn.them.org> To: Daniel Jacobowitz , Andrew Cagney Subject: Re: [PATCH] mips n64 support, part 1 Cc: Kevin Buettner , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-08/txt/msg00011.txt.bz2 On Aug 1, 3:06pm, Daniel Jacobowitz wrote: > On Thu, Aug 01, 2002 at 03:02:18PM -0400, Andrew Cagney wrote: > > >@@ -4352,7 +4354,11 @@ mips_gdbarch_init (struct gdbarch_info i > > > break; > > > case bfd_mach_mips8000: > > > case bfd_mach_mips10000: > > >- mips_abi = MIPS_ABI_N32; > > >+ if (bfd_get_flavour (info.abfd) == bfd_target_elf_flavour > > >+ && elf_elfheader (info.abfd)->e_ident[EI_CLASS] == ELFCLASS64) > > >+ mips_abi = MIPS_ABI_N64; > > >+ else > > >+ mips_abi = MIPS_ABI_N32; > > > break; > > > } > > > } > > > > This bit should at least have a comment explaining the assumptions > > behind it -- have you actually seen this code being triggered? I don't > > think the code is ever reached (unless the executable is very old) as > > the earlier: > > > > /* GCC creates a pseudo-section whose name describes the ABI. */ > > if (mips_abi == MIPS_ABI_UNKNOWN && info.abfd != NULL) > > bfd_map_over_sections (info.abfd, mips_find_abi_section, &mips_abi); > > > > should catch most modern cases. > > Kevin is using IRIX CC, I believe. Yes. > The marker sections are GCC-specific. Actually, I think they're platform specific. In the tests I did yesterday, I didn't see the marker sections in binaries created by gcc either. I'll add a comment though. Kevin