From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17245-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 30701 invoked by alias); 1 Aug 2002 01:11:02 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 30694 invoked from network); 1 Aug 2002 01:11:01 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 1 Aug 2002 01:11:01 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g710wZl08242
	for <gdb-patches@sources.redhat.com>; Wed, 31 Jul 2002 20:58:35 -0400
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g711Avu03558;
	Wed, 31 Jul 2002 21:10:57 -0400
Received: from romulus.sfbay.redhat.com (IDENT:PWPO04tNfIKRRyzmHVsqvMc8JJegGPEc@romulus.sfbay.redhat.com [172.16.27.251])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g711Aum02283;
	Wed, 31 Jul 2002 18:10:56 -0700
Received: (from kev@localhost)
	by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g711As924817;
	Wed, 31 Jul 2002 18:10:54 -0700
Date: Wed, 31 Jul 2002 18:16:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020801011054.ZM24816@localhost.localdomain>
In-Reply-To: Michael Snyder <msnyder@redhat.com>
        "Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit" (Jul 31,  4:21pm)
References: <1020731210452.ZM23445@localhost.localdomain> 
	<3D486843.8007D610@redhat.com> 
	<1020731232203.ZM24308@localhost.localdomain> 
	<3D4870EB.BB9C282A@redhat.com>
To: Michael Snyder <msnyder@redhat.com>
Subject: Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit
Cc: ac131313@redhat.com, gdb-patches@sources.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-07/txt/msg00648.txt.bz2

On Jul 31,  4:21pm, Michael Snyder wrote:

> Kevin Buettner wrote:
> > 
> > On Jul 31,  3:44pm, Michael Snyder wrote:
> > 
> > > >         * mips-tdep.c (mips_push_arguments): Don't assume that
> > > >         ``MIPS_SAVED_REGSIZE < 8'' means that the o64 abi is in use.
> > > >         Instead, test for it explicitly.
> > >
> > > Kevin,
> > >
> > > This change makes things worse for N32.  I haven't tested
> > > N64 yet.  I think we're gonna have to look at these lines
> > > from the perspective of all 3 (6) abis.
> > 
> > Okay, this patch is withdrawn while I retest...
> > 
> > To save some time, can you tell me which N32 regressions you see?
> 
> Buncha failures in structs.exp.
> If you have a look at the tweak that I sent, it might be the thing.

Hmm.  It looks to me like SGI's cc and gcc disagree on the meaning of
the N32 ABI.

When I use the original test (or the tweak that you sent me), I see
the following failures when testing with cc, but not gcc:

    FAIL: gdb.base/structs.exp: p L1
    FAIL: gdb.base/structs.exp: p L2
    FAIL: gdb.base/structs.exp: p L3
    FAIL: gdb.base/structs.exp: p L4
    FAIL: gdb.base/structs.exp: p L5
    FAIL: gdb.base/structs.exp: p L6
    FAIL: gdb.base/structs.exp: p L7
    FAIL: gdb.base/structs.exp: p L9
    FAIL: gdb.base/structs.exp: p L10
    FAIL: gdb.base/structs.exp: p L11
    FAIL: gdb.base/structs.exp: p L12

OTOH, when I use my posted change, I don't see the above failures in cc,
but I do in gcc.

So, it seems that cc wants small structs shifted, but that gcc does not.

Time for me to dig into the ABI documents to find out which compiler's
right...