From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9043 invoked by alias); 30 Jul 2002 18:27:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9036 invoked from network); 30 Jul 2002 18:27:57 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 30 Jul 2002 18:27:57 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g6UIFel23467 for ; Tue, 30 Jul 2002 14:15:40 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g6UIRtu25131 for ; Tue, 30 Jul 2002 14:27:55 -0400 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g6UIRsm26323 for ; Tue, 30 Jul 2002 11:27:54 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g6UIRqO15658 for gdb-patches@sources.redhat.com; Tue, 30 Jul 2002 11:27:52 -0700 Date: Tue, 30 Jul 2002 11:55:00 -0000 From: Kevin Buettner Message-Id: <1020730182752.ZM15657@localhost.localdomain> In-Reply-To: Kevin Buettner "[RFA] gdb.base/shlib-call.exp changes for IRIX" (Jul 29, 3:15pm) References: <1020729221547.ZM11554@localhost.localdomain> To: gdb-patches@sources.redhat.com Subject: Re: [RFA] gdb.base/shlib-call.exp changes for IRIX MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00595.txt.bz2 On Jul 29, 3:15pm, Kevin Buettner wrote: > Some more IRIX related changes. I can break this change up into two > parts if necessary. (The linker flag change is probably reasonably > obvious, but the change to the "step out of shr2" test should be > reviewed.) > > Anyway, regarding the "step out of shr2" test changes, the IRIX > compiler doesn't emit line number information for the epilogue, so we > don't see the step onto the final ``}'' of the function. I don't > see a problem with this behavior. I've revised the test to accept > either behavior. > > I've also revised the messages a little bit to account for the > restructuring of the test. > > Okay to commit? > > * gdb.base/shlib-call.exp (additional_flags): Add linker flags > so that shared libraries created by test will be found. > (step inside shr2): Don't fail if first step ends up stepping > out of the function instead of stopping on the epilogue. I'm also (temporarily) withdrawing this patch since I now have some other changes to make to shlib-call.exp. I'll commit the obvious portions and then repost the part that I want reviewed. Kevin