From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22186 invoked by alias); 23 Jul 2002 01:10:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22057 invoked from network); 23 Jul 2002 01:10:20 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 23 Jul 2002 01:10:20 -0000 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g6N1AfQ19454 for ; Mon, 22 Jul 2002 18:10:41 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g6N1AIb27582 for gdb-patches@sources.redhat.com; Mon, 22 Jul 2002 18:10:18 -0700 Date: Mon, 22 Jul 2002 18:18:00 -0000 From: Kevin Buettner Message-Id: <1020723011017.ZM27581@localhost.localdomain> To: gdb-patches@sources.redhat.com Subject: [PATCH] aix-thread.c: Don't use %llx format MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00451.txt.bz2 I've committed the patch below. In addition to fixing the problem mentioned in the subject line, I've added back the printing of newlines in debug messages that were inadvertently removed when I eliminated the DEBUG macro (and company). * aix-thread.c (language.h): Include. (ptrace_check, pdc_symbol_addrs, pdc_read_regs, pdc_write_regs) (pdc_read_data, pdc_write_data, pdc_alloc, pdc_realloc, pdc_dealloc): Print newlines at end of debug messages. (pdc_symbol_addrs, pdc_read_regs, pdc_write_regs, pdc_read_data) (pdc_write_data): Use local_hex_string() instead of %llx formats. Index: aix-thread.c =================================================================== RCS file: /cvs/src/src/gdb/aix-thread.c,v retrieving revision 1.10 diff -u -p -r1.10 aix-thread.c --- aix-thread.c 23 Jul 2002 00:34:29 -0000 1.10 +++ aix-thread.c 23 Jul 2002 00:59:57 -0000 @@ -48,6 +48,8 @@ #include "inferior.h" #include "regcache.h" #include "gdbcmd.h" +#include "language.h" /* for local_hex_string() */ +#include "ppc-tdep.h" #if 0 #include "coff/internal.h" /* for libcoff.h */ @@ -63,7 +65,6 @@ #endif #include #include -#include "ppc-tdep.h" /* Whether to emit debugging output. */ static int debug_aix_thread; @@ -240,7 +241,7 @@ ptrace_check (int req, int id, int ret) { if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - "ptrace (%d, %d) = %d (errno = %d)", + "ptrace (%d, %d) = %d (errno = %d)\n", req, id, ret, errno); return ret == -1 ? 0 : 1; } @@ -295,7 +296,7 @@ pdc_symbol_addrs (pthdb_user_t user, pth if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - "pdc_symbol_addrs (user = %ld, symbols = 0x%lx, count = %d)", + "pdc_symbol_addrs (user = %ld, symbols = 0x%lx, count = %d)\n", user, (long) symbols, count); for (i = 0; i < count; i++) @@ -303,7 +304,7 @@ pdc_symbol_addrs (pthdb_user_t user, pth name = symbols[i].name; if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - " symbols[%d].name = \"%s\"", i, name); + " symbols[%d].name = \"%s\"\n", i, name); if (!*name) symbols[i].addr = 0; @@ -312,17 +313,17 @@ pdc_symbol_addrs (pthdb_user_t user, pth if (!(ms = lookup_minimal_symbol (name, NULL, NULL))) { if (debug_aix_thread) - fprintf_unfiltered (gdb_stdlog, " returning PDC_FAILURE"); + fprintf_unfiltered (gdb_stdlog, " returning PDC_FAILURE\n"); return PDC_FAILURE; } symbols[i].addr = SYMBOL_VALUE_ADDRESS (ms); } if (debug_aix_thread) - fprintf_unfiltered (gdb_stdlog, " symbols[%d].addr = 0x%llx", - i, symbols[i].addr); + fprintf_unfiltered (gdb_stdlog, " symbols[%d].addr = %s\n", + i, local_hex_string (symbols[i].addr)); } if (debug_aix_thread) - fprintf_unfiltered (gdb_stdlog, " returning PDC_SUCCESS"); + fprintf_unfiltered (gdb_stdlog, " returning PDC_SUCCESS\n"); return PDC_SUCCESS; } @@ -351,8 +352,8 @@ pdc_read_regs (pthdb_user_t user, struct ptsprs sprs32; if (debug_aix_thread) - fprintf_unfiltered (gdb_stdlog, "pdc_read_regs tid=%d flags=%llx\n", - (int) tid, flags); + fprintf_unfiltered (gdb_stdlog, "pdc_read_regs tid=%d flags=%s\n", + (int) tid, local_hex_string (flags)); /* General-purpose registers. */ if (flags & PTHDB_FLAG_GPRS) @@ -417,8 +418,8 @@ pdc_write_regs (pthdb_user_t user, however this code is untested. */ if (debug_aix_thread) - fprintf_unfiltered (gdb_stdlog, "pdc_write_regs tid=%d flags=%llx\n", - (int) tid, flags); + fprintf_unfiltered (gdb_stdlog, "pdc_write_regs tid=%d flags=%s\n", + (int) tid, local_hex_string (flags)); /* General-purpose registers. */ if (flags & PTHDB_FLAG_GPRS) @@ -462,14 +463,14 @@ pdc_read_data (pthdb_user_t user, void * if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - "pdc_read_data (user = %ld, buf = 0x%lx, addr = 0x%llx, len = %ld)", - user, (long) buf, addr, len); + "pdc_read_data (user = %ld, buf = 0x%lx, addr = %s, len = %ld)\n", + user, (long) buf, local_hex_string (addr), len); status = target_read_memory (addr, buf, len); ret = status == 0 ? PDC_SUCCESS : PDC_FAILURE; if (debug_aix_thread) - fprintf_unfiltered (gdb_stdlog, " status=%d, returning %s", + fprintf_unfiltered (gdb_stdlog, " status=%d, returning %s\n", status, pd_status2str (ret)); return ret; } @@ -484,14 +485,14 @@ pdc_write_data (pthdb_user_t user, void if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - "pdc_write_data (user = %ld, buf = 0x%lx, addr = 0x%llx, len = %ld)", - user, (long) buf, addr, len); + "pdc_write_data (user = %ld, buf = 0x%lx, addr = %s, len = %ld)\n", + user, (long) buf, local_hex_string (addr), len); status = target_write_memory (addr, buf, len); ret = status == 0 ? PDC_SUCCESS : PDC_FAILURE; if (debug_aix_thread) - fprintf_unfiltered (gdb_stdlog, " status=%d, returning %s", status, + fprintf_unfiltered (gdb_stdlog, " status=%d, returning %s\n", status, pd_status2str (ret)); return ret; } @@ -504,12 +505,12 @@ pdc_alloc (pthdb_user_t user, size_t len { if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - "pdc_alloc (user = %ld, len = %ld, bufp = 0x%lx)", + "pdc_alloc (user = %ld, len = %ld, bufp = 0x%lx)\n", user, len, (long) bufp); *bufp = xmalloc (len); if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - " malloc returned 0x%lx", (long) *bufp); + " malloc returned 0x%lx\n", (long) *bufp); /* Note: xmalloc() can't return 0; therefore PDC_FAILURE will never be returned. */ @@ -526,12 +527,12 @@ pdc_realloc (pthdb_user_t user, void *bu { if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - "pdc_realloc (user = %ld, buf = 0x%lx, len = %ld, bufp = 0x%lx)", + "pdc_realloc (user = %ld, buf = 0x%lx, len = %ld, bufp = 0x%lx)\n", user, (long) buf, len, (long) bufp); *bufp = xrealloc (buf, len); if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - " realloc returned 0x%lx", (long) *bufp); + " realloc returned 0x%lx\n", (long) *bufp); return *bufp ? PDC_SUCCESS : PDC_FAILURE; } @@ -543,7 +544,7 @@ pdc_dealloc (pthdb_user_t user, void *bu { if (debug_aix_thread) fprintf_unfiltered (gdb_stdlog, - "pdc_free (user = %ld, buf = 0x%lx)", user, + "pdc_free (user = %ld, buf = 0x%lx)\n", user, (long) buf); xfree (buf); return PDC_SUCCESS;