From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26403 invoked by alias); 22 Jul 2002 22:30:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26396 invoked from network); 22 Jul 2002 22:30:06 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 22 Jul 2002 22:30:06 -0000 Received: from romulus.sfbay.redhat.com (IDENT:04MFiQwaAGxQiuXiVlffmc0ZF+vGbZCL@romulus.sfbay.redhat.com [172.16.27.251]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g6MMURQ18876; Mon, 22 Jul 2002 15:30:27 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g6MMU3926190; Mon, 22 Jul 2002 15:30:03 -0700 Date: Mon, 22 Jul 2002 15:52:00 -0000 From: Kevin Buettner Message-Id: <1020722223002.ZM26189@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: Another patch to aix-thread.c" (Jul 22, 3:43pm) References: <3D37144C.1AEBF992@redhat.com> <1020722192522.ZM25196@localhost.localdomain> <3D3C6046.4010007@ges.redhat.com> To: Andrew Cagney , Kevin Buettner Subject: Re: Another patch to aix-thread.c Cc: Michael Snyder , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00447.txt.bz2 On Jul 22, 3:43pm, Andrew Cagney wrote: > > + regcache_collect (regno, iar); > > + regcache_collect (regno + 1, msr); > > Suggest ``regno + 0''. Otherwize gdb_indent.sh will mess up your nice > alignment. I agree that this is a good idea. However, I'm about to make some changes which will obviate the use of regno + N. I.e, I'm about to transform the above into the following: struct gdbarch_tdep *tdep = gdbarch_tdep (current_gdbarch); ... regcache_collect (PC_REGNUM, iar); regcache_collect (tdep->ppc_ps_regnum, msr); ... This will also eliminate the use of FIRST_UISA_SP_REGNUM from the file. While I'm at it, I'll also look at eliminating this macro from rs6000-nat.c which means that it can be eliminated from GDB entirely. (It bothered me that aix-thread.c was making assumptions about the order of the registers. Also, it was more difficult to verify the correctness by having expressions of the form "regno + small_offset". I was having to look elsewhere to verify that the specified offset was correct.) Kevin