From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20591 invoked by alias); 13 Jul 2002 01:15:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20492 invoked from network); 13 Jul 2002 01:15:44 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 13 Jul 2002 01:15:44 -0000 Received: from romulus.sfbay.redhat.com (IDENT:KRpYYk/6Bf7Ga/joaXx+6pdahzMhpy7P@romulus.sfbay.redhat.com [172.16.27.251]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g6D1GHQ03681; Fri, 12 Jul 2002 18:16:17 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g6D1FUD10496; Fri, 12 Jul 2002 18:15:30 -0700 Date: Sat, 13 Jul 2002 05:25:00 -0000 From: Kevin Buettner Message-Id: <1020713011530.ZM10495@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: [PATCH RFC] AIX thread support" (Jul 12, 6:59pm) References: <1020712192417.ZM7533@localhost.localdomain> <3D2F5F6F.9080308@ges.redhat.com> To: Andrew Cagney Subject: Re: [PATCH RFC] AIX thread support Cc: Kevin Buettner , gdb-patches@sources.redhat.com, nick@duffek.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-07/txt/msg00291.txt.bz2 On Jul 12, 6:59pm, Andrew Cagney wrote: > > From Nicholas Duffek (with minor changes by Martin Hunt, > > Louis Hamilton, and Kevin Buettner): > > * aix-thread.c: New file. > > * Makefile.in (ALLDEPFILES): Add aix-thread.c. > > (aix-thread.o): New rule. > > * configure.host (gdb_host): Set to aix432 on AIX 4.3.2+. > > * config/powerpc/aix432.mh: New file. > [...] > A quick glance suggests a review is needed. For instance, from a > coding (not thread -> MichaelS) viewpoint ``#define DEBUG 0'' should be > handled at run-time and should be written to ``gdb_stdlog''. If > anything, perhaphs like for ada, this file could be initially commited, > but not actually included/enabled. That should at least make the review > process easier. As suggested, I've commited aix-thread.c to make the review process easier. Keep in mind that aix-thread.c will only be used for native AIX builds. As such, I think the criteria for including/enabling this code should be much lower than that for core code or even target specific code. I do agree that there are a number of things in this file which should be cleaned up over time. However, for the initial review, I suggest that we focus on issues which might make overall GDB maintenance or future GDB development more difficult. Only issues which meet these criteria should prevent aix-thread.c from being accepted. I certainly have no objection, however, to reviewers identifying other cleanups that should occur over time. I think your comment regarding ``#define DEBUG 0'' is a good example of this. Kevin