From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10953 invoked by alias); 27 Jun 2002 18:39:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10943 invoked from network); 27 Jun 2002 18:39:24 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 27 Jun 2002 18:39:24 -0000 Received: from romulus.sfbay.redhat.com (IDENT:m+H78mWWcBdmnAf2bouqaYXzMyP9JcPm@romulus.sfbay.redhat.com [172.16.27.251]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g5RIefQ26298; Thu, 27 Jun 2002 11:40:41 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g5RIdH021530; Thu, 27 Jun 2002 11:39:17 -0700 Date: Thu, 27 Jun 2002 11:39:00 -0000 From: Kevin Buettner Message-Id: <1020627183917.ZM21529@localhost.localdomain> In-Reply-To: Andrew Volkov "RE: [RFA/RFC] blockframe.c Fix errorneous addr check" (Jun 27, 10:08pm) References: <2E74F312D6980D459F3A05492BA40F8DFE33AA@clue.transas.com> To: Andrew Volkov , Daniel Jacobowitz Subject: Re: [RFA/RFC] blockframe.c Fix errorneous addr check Cc: gdb-patches@sources.redhat.com, jimb@redhat.com, ezannoni@redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-06/txt/msg00560.txt.bz2 On Jun 27, 10:08pm, Andrew Volkov wrote: > Daniel you're right, this bug in coffread.c(complete_symtab) function, > rather, in invalid calculating of current_source_end_addr: > > current_source_end_addr = start_addr + size; > > but must be: > > current_source_end_addr = start_addr + size + ; > > As I understand, since machine address size is not known at time of parsing > coff file, then we have big trouble :(. Could you explain why you need to add in the size of an address? Assuming it is needed, won't TARGET_PTR_BIT / TARGET_CHAR_BIT provide the correct size? Kevin