From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9565 invoked by alias); 25 Jun 2002 02:13:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9553 invoked from network); 25 Jun 2002 02:13:24 -0000 Received: from unknown (HELO potter.sfbay.redhat.com) (205.180.83.107) by sources.redhat.com with SMTP; 25 Jun 2002 02:13:24 -0000 Received: from romulus.sfbay.redhat.com (remus.sfbay.redhat.com [172.16.27.252]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g5P2EpQ13228; Mon, 24 Jun 2002 19:14:51 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g5P2DG521493; Mon, 24 Jun 2002 19:13:16 -0700 Date: Mon, 24 Jun 2002 19:13:00 -0000 From: Kevin Buettner Message-Id: <1020625021316.ZM21492@localhost.localdomain> In-Reply-To: Joel Brobecker "[RFA] Tru64 - wrong list of shared libraries" (Jun 17, 10:47pm) References: <20020617224743.N23404@gnat.com> To: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: [RFA] Tru64 - wrong list of shared libraries MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-06/txt/msg00499.txt.bz2 On Jun 17, 10:47pm, Joel Brobecker wrote: > * solib-osf.c (open_map): Compute the list of shread libraries > loaded by the inferior, rather than the list of libraires loaded > by GDB itself. Otherwise, GDB ends up reading the symbols from > the wrong shared libraries... I didn't understand your change at first, but that was due to the fact that I didn't understand what ldr_my_process() does. I've located some documentation (via Google) and have remedied that situation. As alluded to in your ChangeLog entry, ldr_my_process() will retrieve the "unique identifier" for the current process, i.e. gdb, which is clearly not correct. Presumably, the pid component of GDB's inferior_ptid is the same as the "unique identifier" used by the ldr_ routines. If it's not, then we ought to be calling a function which does the translation. I don't know of any such function though, so I think your change is okay. (For the moment anyway.) > OK to commit? Yes, with the following changes... First, fix the typos in your ChangeLog entry: s/shread/shared/ s/libraires/libraries/ s/itself. /itself. / Second, add a comment similar to the following just before the line that you changed: /* Note: As originally written, ldr_my_process() was used to obtain the value for ctxt->proc. This is incorrect, however, since ldr_my_process() retrieves the "unique identifier" associated with the current process (i.e. GDB) and not the one being debugged. Presumably, the pid of the process being debugged is compatible with the "unique identifier" used by the ldr_ routines, so we use that. */ Thanks, Kevin