From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15230-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 4403 invoked by alias); 9 May 2002 16:56:27 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 4343 invoked from network); 9 May 2002 16:56:24 -0000
Received: from unknown (HELO cygnus.com) (205.180.83.203)
  by sources.redhat.com with SMTP; 9 May 2002 16:56:24 -0000
Received: from romulus.sfbay.redhat.com (romulus.sfbay.redhat.com [172.16.27.251])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id JAA04575;
	Thu, 9 May 2002 09:56:21 -0700 (PDT)
Received: (from kev@localhost)
	by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g49GuH213421;
	Thu, 9 May 2002 09:56:17 -0700
Date: Thu, 09 May 2002 09:56:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020509165617.ZM13420@localhost.localdomain>
In-Reply-To: Petr Sorfa <petrs@caldera.com>
        "[PATCH] IA64 fix for breakpoints on L in MLX instruction bundles" (May  9,  1:00pm)
References: <3CDAAB19.4780AA1F@caldera.com>
To: Petr Sorfa <petrs@caldera.com>,
        "gdb-patches@sources.redhat.com
 " <gdb-patches@sources.redhat.com>
Subject: Re: [PATCH] IA64 fix for breakpoints on L in MLX instruction bundles
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-05/txt/msg00278.txt.bz2

On May 9,  1:00pm, Petr Sorfa wrote:

> Patch for handling breakpoints on the L instruction type in an MLX
> bundle.
> 
> 
> 2002-05-09  Petr Sorfa (petrs@caldera.com)
> 
>         * ia64-tdep.c: Handle breakpoints on L instruction type
>         in MLX instruction bundle by moving the breakpoint to
>         the third slot (X instruction type) as L holds only data.

Approved, but I'd like you to fix a minor indentation issue prior
to committing it though...

> +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> +   {
> +     slotnum = 2;
> +   }

This should look like this instead:

> +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> +     {
> +       slotnum = 2;
> +     }

Or just:

> +   if (slotnum == 1 && template_encoding_table[template][1] == L)
> +     slotnum = 2;

Thanks,

Kevin