From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10972 invoked by alias); 22 Apr 2002 07:59:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10959 invoked from network); 22 Apr 2002 07:59:22 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 22 Apr 2002 07:59:22 -0000 Received: from romulus.sfbay.redhat.com (romulus.sfbay.redhat.com [172.16.27.251]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id AAA03571; Mon, 22 Apr 2002 00:59:20 -0700 (PDT) Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g3M7xBL32310; Mon, 22 Apr 2002 00:59:11 -0700 Date: Mon, 22 Apr 2002 00:59:00 -0000 From: Kevin Buettner Message-Id: <1020422075910.ZM32309@localhost.localdomain> In-Reply-To: Andrew Cagney "[rfa/rfc:ppc] svr4 and not just ELFOSABI_LINUX for function parsing et.al." (Apr 22, 12:29am) References: <3CC391A7.4090607@cygnus.com> To: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [rfa/rfc:ppc] svr4 and not just ELFOSABI_LINUX for function parsing et.al. MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-04/txt/msg00773.txt.bz2 On Apr 22, 12:29am, Andrew Cagney wrote: > I was finding that for a non-GNU/Linux SVR4 PPC platform malloc() was > failing because RS6000 TOC func-ptr code was being selected: > > /* Handle RS/6000 function pointers. */ > set_gdbarch_convert_from_func_ptr_addr (gdbarch, > rs6000_convert_from_func_ptr_addr); > > the attached patch changes things to select all of: > > set_gdbarch_frameless_function_invocation (gdbarch, > ppc_linux_frameless_function_invocation); > set_gdbarch_frame_chain (gdbarch, ppc_linux_frame_chain); > set_gdbarch_frame_saved_pc (gdbarch, ppc_linux_frame_saved_pc); > > set_gdbarch_frame_init_saved_regs (gdbarch, > ppc_linux_frame_init_saved_regs); > set_gdbarch_init_extra_frame_info (gdbarch, > ppc_linux_init_extra_frame_info); > > set_gdbarch_memory_remove_breakpoint (gdbarch, > > ppc_linux_memory_remove_breakpoint); > set_solib_svr4_fetch_link_map_offsets > (gdbarch, ppc_linux_svr4_fetch_link_map_offsets); > > when svr4_abi. It certainly improves things (fails went from 136 -> 80) > but I'm not 100% certain if this is correct for all the above - I > suspect it is overkill :-/ It looks okay to me. I have no problem with you checking it in. Kevin