From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23326 invoked by alias); 9 Apr 2002 02:17:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23312 invoked from network); 9 Apr 2002 02:17:02 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 9 Apr 2002 02:17:02 -0000 Received: from romulus.sfbay.redhat.com (romulus.sfbay.redhat.com [172.16.27.251]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id TAA14165; Mon, 8 Apr 2002 19:16:59 -0700 (PDT) Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g392GYf22923; Mon, 8 Apr 2002 19:16:34 -0700 Date: Mon, 08 Apr 2002 19:17:00 -0000 From: Kevin Buettner Message-Id: <1020409021634.ZM22922@localhost.localdomain> In-Reply-To: Elena Zannoni "Re: [PATCH] rs6000-tdep.c: Use set_gdbarch_print_insn()" (Apr 8, 9:18pm) References: <1020409001204.ZM22336@localhost.localdomain> <15538.16762.410385.501030@localhost.redhat.com> To: Elena Zannoni Subject: Re: [PATCH] rs6000-tdep.c: Use set_gdbarch_print_insn() Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-04/txt/msg00342.txt.bz2 On Apr 8, 9:18pm, Elena Zannoni wrote: > tm_print_insn shouldn't be used/needed anymore. I have removed gdbtk's uses > of tm_print_insn a while back. I've just committed the following patch which takes care of this... * rs6000-tdep.c (rs6000_gdbarch_init): Don't set tm_print_insn; it's no longer required. Index: rs6000-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v retrieving revision 1.48 diff -u -p -r1.48 rs6000-tdep.c --- rs6000-tdep.c 9 Apr 2002 01:41:46 -0000 1.48 +++ rs6000-tdep.c 9 Apr 2002 02:05:41 -0000 @@ -2458,6 +2458,7 @@ rs6000_gdbarch_init (struct gdbarch_info unsigned long mach; bfd abfd; int osabi, sysv_abi; + gdbarch_print_insn_ftype *print_insn; from_xcoff_exec = info.abfd && info.abfd->format == bfd_object && bfd_get_flavour (info.abfd) == bfd_target_xcoff_flavour; @@ -2574,13 +2575,14 @@ rs6000_gdbarch_init (struct gdbarch_info off += regsize (v->regs + i, wordsize); } - /* Select instruction printer. Note: tm_print_insn is still used by - gdbtk (insight), so we set both tm_print_insn and the gdbarch - method. */ - tm_print_insn = arch == power ? print_insn_rs6000 : - info.byte_order == BFD_ENDIAN_BIG ? print_insn_big_powerpc : - print_insn_little_powerpc; - set_gdbarch_print_insn (gdbarch, tm_print_insn); + /* Select instruction printer. */ + if (arch == power) + print_insn = print_insn_rs6000; + else if (info.byte_order == BFD_ENDIAN_BIG) + print_insn = print_insn_big_powerpc; + else + print_insn = print_insn_little_powerpc; + set_gdbarch_print_insn (gdbarch, print_insn); set_gdbarch_read_pc (gdbarch, generic_target_read_pc); set_gdbarch_write_pc (gdbarch, generic_target_write_pc);