From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13977-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 14009 invoked by alias); 6 Apr 2002 00:03:03 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 14002 invoked from network); 6 Apr 2002 00:03:02 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 6 Apr 2002 00:03:02 -0000
Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA06651;
	Fri, 5 Apr 2002 16:03:00 -0800 (PST)
Received: (from kev@localhost)
	by cse.cygnus.com (8.11.6/8.11.6) id g3602dB02219;
	Fri, 5 Apr 2002 17:02:39 -0700
Date: Fri, 05 Apr 2002 16:03:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020406000239.ZM2218@localhost.localdomain>
In-Reply-To: Andrew Cagney <ac131313@cygnus.com>
        "[rfa:sparc] Remove write_fp() from sparc-tdep.c" (Apr  5,  5:04pm)
References: <3CAE1F58.4070601@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>, gdb-patches@sources.redhat.com
Subject: Re: [rfa:sparc] Remove write_fp() from sparc-tdep.c
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-04/txt/msg00198.txt.bz2

On Apr 5,  5:04pm, Andrew Cagney wrote:

>    if (strcmp (target_shortname, "sim") != 0)
>      {
> -      write_fp (old_sp);
> -
> +      if (gdbarch_tdep (current_gdbarch)->intreg_size == 8)

How about

	 if (GDB_TARGET_IS_SPARC64)

instead?  (That matches the existing convention in the rest of the
file better.)

Aside from that, I think your change is fine.  Something to consider
though is whether the entire

    if (strcmp (target_shortname, "sim") != 0)
      {
        ...
      }

could simply go away.  I.e, let the "sim" case just use the non-sim
code.

Kevin