From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13198-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 19719 invoked by alias); 5 Mar 2002 16:30:22 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 19516 invoked from network); 5 Mar 2002 16:30:08 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 5 Mar 2002 16:30:08 -0000
Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id IAA07402;
	Tue, 5 Mar 2002 08:30:01 -0800 (PST)
Received: (from kev@localhost)
	by cse.cygnus.com (8.11.6/8.11.6) id g25GTlW18588;
	Tue, 5 Mar 2002 09:29:47 -0700
Date: Tue, 05 Mar 2002 08:30:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020305162947.ZM18587@localhost.localdomain>
In-Reply-To: Michal Ludvig <mludvig@suse.cz>
        "x86-64-tdep.h cleanup" (Mar  5,  4:56pm)
References: <3C84EAA8.2000900@suse.cz>
X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera)
To: Michal Ludvig <mludvig@suse.cz>, gdb-patches@sources.redhat.com
Subject: Re: x86-64-tdep.h cleanup
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-03/txt/msg00050.txt.bz2

On Mar 5,  4:56pm, Michal Ludvig wrote:

> As it was recommended by lots of people here I moved <sys/reg.h> along 
> with regmap from x86-64-tdep.h to x86-64-linux-nat.c.
> Also to let x86-64-tdep.h contain only #defines, I moved declarations of 
> x86_64_linux_frame_saved_pc and x86_64_linux_saved_pc_after_call to 
> x86-64-tdep.c. Are these changes OK to commit?
> 
> Michal Ludvig
> 
> Index: ChangeLog
> from Michal Ludvig  <mludvig@suse.cz>
> 
> * x86-64-tdep.h (sys/reg.h, x86_64_regmap): Moved to x86-64-linux-nat.c
> (x86_64_linux_frame_saved_pc,
> x86_64_linux_saved_pc_after_call): Moved to x86-64-tdep.c
> * x86-64-linux-nat.c (sys/reg.h, x86_64_regmap): Moved here
> from x86-64-tdep.h
> * x86-64-tdep.c (x86_64_linux_frame_saved_pc,
> x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h


Michael,

I'm not the maintainer of the files in questions, but your changes
look okay to me.

Make sure your ChangeLog entries are indented by a tab and make sure
that you end your remarks with a period.  Also, it's been pointed out
to me in the past that an entry like this:

	* x86-64-tdep.c (x86_64_linux_frame_saved_pc,
	x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h.

should be written like this instead:

	* x86-64-tdep.c (x86_64_linux_frame_saved_pc)
	(x86_64_linux_saved_pc_after_call): Moved here from x86-64-tdep.h.

(I've been told that emacs is happier if ChangeLog entries are
formatted this way.)

Kevin