From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-12994-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 10729 invoked by alias); 21 Feb 2002 21:46:32 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 9858 invoked from network); 21 Feb 2002 21:46:10 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 21 Feb 2002 21:46:10 -0000
Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id NAA10097;
	Thu, 21 Feb 2002 13:46:05 -0800 (PST)
Received: (from kev@localhost)
	by cse.cygnus.com (8.11.6/8.11.6) id g1LLjkF04221;
	Thu, 21 Feb 2002 14:45:46 -0700
Date: Thu, 21 Feb 2002 13:46:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020221214546.ZM4220@localhost.localdomain>
In-Reply-To: Elena Zannoni <ezannoni@redhat.com>
        "Re: [RFA] ppc-linux-nat.c AltiVec regs ptrace" (Feb 21,  4:25pm)
References: <15476.1308.919907.110811@localhost.redhat.com> 
	<1020221153240.ZM2943@localhost.localdomain> 
	<15477.26039.907368.838837@localhost.redhat.com>
X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera)
To: Elena Zannoni <ezannoni@redhat.com>
Subject: Re: [RFA] ppc-linux-nat.c AltiVec regs ptrace
Cc: gdb-patches@sources.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-02/txt/msg00609.txt.bz2

On Feb 21,  4:25pm, Elena Zannoni wrote:

> Ok, here is the patch again [(N+1)th time!:-)]
[...]
> Note the GNU/Linux change freebie!

Cool!

> 2002-02-21  Elena Zannoni  <ezannoni@redhat.com>
> 
> 	* ppc-linux-nat.c (PTRACE_GETVRREGS, PTRACE_SETVRREGS): Define.
> 	(have_ptrace_getvrregs): Define for run time checks.
> 	(fetch_register, store_register): Fetch/store altivec register
> 	when needed.
> 	(fetch_altivec_register, store_altivec-register): New functions.

Nit: Make that store_altivec_register.  (Change hyphen to underscore.)

> 	(supply_vrregset, fill_vrregset): New functions.
> 	(fetch_altivec_registers, store_altivec_registers): New functions.
> 	(fetch_ppc_registers, store_ppc_registers): Fetch/store altivec
> 	registers as well.
> 	Use GNU/Linux where applicable.

Looks good otherwise.  Check it in!

Thanks,

Kevin