From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11908-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 30226 invoked by alias); 13 Jan 2002 19:48:04 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 30090 invoked from network); 13 Jan 2002 19:47:57 -0000
Received: from unknown (HELO cygnus.com) (205.180.230.5)
  by sources.redhat.com with SMTP; 13 Jan 2002 19:47:57 -0000
Received: from cse.cygnus.com (cse.sfbay.redhat.com [205.180.230.236])
	by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA25259;
	Sun, 13 Jan 2002 11:47:54 -0800 (PST)
Received: (from kev@localhost)
	by cse.cygnus.com (8.11.6/8.11.6) id g0DJjx726002;
	Sun, 13 Jan 2002 12:45:59 -0700
Date: Sun, 13 Jan 2002 11:48:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
Message-Id: <1020113194559.ZM26001@localhost.localdomain>
In-Reply-To: Andrew Cagney <ac131313@cygnus.com>
        "Re: [PATCH] ARM: Eliminate EXTRA_FRAME_INFO & FRAME_FIND_SAVED_REGS" (Jan 13,  2:08pm)
References: <200201131528.PAA21457@cam-mail2.cambridge.arm.com> 
	<1020113172426.ZM25643@localhost.localdomain> 
	<3C41D47F.1020302@cygnus.com>  <3C41DB31.5000308@cygnus.com>
X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera)
To: Andrew Cagney <ac131313@cygnus.com>, Kevin Buettner <kevinb@redhat.com>,
        Richard.Earnshaw@arm.com
Subject: Re: [PATCH] ARM: Eliminate EXTRA_FRAME_INFO & FRAME_FIND_SAVED_REGS
Cc: gdb-patches@sources.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2002-01/txt/msg00353.txt.bz2

On Jan 13,  2:08pm, Andrew Cagney wrote:
> Subject: Re: [PATCH] ARM: Eliminate EXTRA_FRAME_INFO & FRAME_FIND_SAVED_RE
> > +      caller_fi.saved_regs = (CORE_ADDR *) xcalloc (1, SIZEOF_FRAME_SAVED_REGS);
> > +      old_chain = make_cleanup (xfree, caller_fi.saved_regs);
> > +      caller_fi.extra_info = xcalloc (1, sizeof (struct frame_extra_info));
> > +      make_cleanup (xfree, caller_fi.extra_info);
> > 
> > 
> > That calloc() call caught my attention.
> > 
> > Just call frame_saved_regs_zalloc() and frame_obstack_alloc().  Since all is on the frame obstack, worrying about cleanups is unnecessary.
> 
> Hmm, no, sorry.  That code is up to something wierd so it can't put the 
> stuff on the obstack.  However, I would just use xmalloc().

With an explicit memset following the allocation?  (Otherwise, they're
not initialized.)

Kevin