From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24924 invoked by alias); 2 Aug 2007 00:40:41 -0000 Received: (qmail 24906 invoked by uid 22791); 2 Aug 2007 00:40:41 -0000 X-Spam-Check-By: sourceware.org Received: from b.mail.sonic.net (HELO b.mail.sonic.net) (64.142.19.5) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 02 Aug 2007 00:40:36 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by b.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l720eIex022438; Wed, 1 Aug 2007 17:40:18 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Wed, 1 Aug 2007 17:40:18 -0700 (PDT) Message-ID: <10128.12.7.175.2.1186015218.squirrel@webmail.sonic.net> In-Reply-To: <20070801220000.GA4705@lucon.org> References: <6845.12.7.175.2.1186002936.squirrel@webmail.sonic.net> <20070801220000.GA4705@lucon.org> Date: Thu, 02 Aug 2007 00:40:00 -0000 Subject: Re: [PATCH] opcodes/i386-dis.c, print_insn, null ptr. From: msnyder@sonic.net To: "H.J. Lu" Cc: msnyder@sonic.net, gdb-patches@sourceware.org, binutils@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00018.txt.bz2 > On Wed, Aug 01, 2007 at 02:15:36PM -0700, msnyder@sonic.net wrote: >> If we come to this point via the default case in the switch >> statement above, we will not have updated 'dp' and dp->name >> will still be null. Then putop will dereference it. >> > >> 2007-08-01 Michael Snyder >> >> * i386-dis.c (print_insn): Guard against NULL. >> > > It is OK. Committed, thanks.