From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30278 invoked by alias); 9 Dec 2001 21:24:51 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29723 invoked from network); 9 Dec 2001 21:23:33 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 9 Dec 2001 21:23:33 -0000 Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id NAA05998; Sun, 9 Dec 2001 13:23:31 -0800 (PST) Received: (from kev@localhost) by cse.cygnus.com (8.9.3/8.9.3) id OAA18907; Sun, 9 Dec 2001 14:23:24 -0700 Date: Sun, 09 Dec 2001 13:24:00 -0000 From: Kevin Buettner Message-Id: <1011209212323.ZM18906@ocotillo.lan> In-Reply-To: Elena Zannoni "[RFA] ppc: include register numbers in gdbarch_tdep structure." (Dec 9, 3:04pm) References: <15379.50110.429092.453327@krustylu.cygnus.com> X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera) To: Elena Zannoni , gdb-patches@sources.redhat.com Subject: Re: [RFA] ppc: include register numbers in gdbarch_tdep structure. MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2001-12/txt/msg00257.txt.bz2 On Dec 9, 3:04pm, Elena Zannoni wrote: > This is a new patch for > > http://sources.redhat.com/ml/gdb-patches/2001-12/msg00160.html > > Tested on aix4.3, solaris-x-powerpc-eabi, ppcnbsd, ppclinux. > > Elena > > 2001-12-09 Elena Zannoni > > * config/rs6000/tm-rs6000.h (STAB_REG_TO_REGNUM): Remove > definition, it is now multiarched. > * ppc-tdep.h (struct gdbarch_tdep): Move from rs6000-tdep.c. Add > fields for special register numbers. > * rs6000-tdep.c (rs6000_gdbarch_init): Initialize new tdep special > regnum fields. > (rs6000_saved_pc_after_call): Use gdbarch_tdep registers fields > instead of hardcoded macros. > (branch_dest, rs6000_pop_frame, rs6000_fix_call_dummy, > ppc_push_return_address, rs6000_frame_saved_pc, > frame_get_saved_regs, rs6000_frame_chain, > rs6000_store_return_value): Ditto. > (rs6000_stab_reg_to_regnum): New function. > * ppcnbsd-nat.c (fetch_inferior_registers, > store_inferior_registers, fetch_core_registers): Ditto. > * ppc-linux-tdep.c (ppc_linux_in_sigtramp, > ppc_linux_frame_init_saved_regs): Ditto. > * ppc-linux-nat.c (ppc_register_u_addr, supply_gregset, > fill_gregset): Ditto. > * ppc-bdm.c (bdm_ppc_fetch_registers, bdm_ppc_store_registers): > Ditto. Approved. Though I do wonder if it was really necessary to move register numbers which are truly constant to the gdbarch_tdep struct. BTW, this wouldn't bother me so much if we could use inline functions in C. Kevin