From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9950 invoked by alias); 3 Dec 2001 18:26:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9903 invoked from network); 3 Dec 2001 18:26:25 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 3 Dec 2001 18:26:25 -0000 Received: from cse.cygnus.com (cse.cygnus.com [205.180.230.236]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id KAA11745; Mon, 3 Dec 2001 10:26:23 -0800 (PST) Received: (from kev@localhost) by cse.cygnus.com (8.9.3/8.9.3) id LAA32535; Mon, 3 Dec 2001 11:26:14 -0700 Date: Mon, 03 Dec 2001 10:26:00 -0000 From: Kevin Buettner Message-Id: <1011203182614.ZM32534@ocotillo.lan> In-Reply-To: Elena Zannoni "Re: [PATCH] Define SVR4 link map offset fetcher for Linux/PPC" (Dec 3, 12:38am) References: <1011201003404.ZM23547@ocotillo.lan> <3C0A6CB3.9080104@cygnus.com> <15371.4042.166544.538072@krustylu.cygnus.com> X-Mailer: Z-Mail (4.0.1 13Jan97 Caldera) To: Elena Zannoni , Andrew Cagney Subject: Re: [PATCH] Define SVR4 link map offset fetcher for Linux/PPC Cc: Kevin Buettner , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2001-12/txt/msg00041.txt.bz2 On Dec 3, 12:38am, Elena Zannoni wrote: > Andrew Cagney writes: > > > I've tested this patch on AIX (to make sure I didn't break the build > > > or cause any regressions) and also in a Linux/x86 cross Linux/PPC test > > > environment. > > > > Kevin, did you try this with --target=powerpc-eabi as listed in the > > MAINTAINERS? I'm seeing a -Werror of solib_add() undefined: > > > > > /home/scratch/PENDING/rm-obsolete/src/gdb/solib-svr4.c:912: warning: implicit declaration of function `solib_add' > > > gmake[1]: *** [solib-svr4.o] Error 1 > > > gmake[1]: Leaving directory `/home/scratch/PENDING/rm-obsolete/carp/X-powerpc-eabi/gdb' > > > gmake: *** [all-gdb] Error 2 > > > > enjoy, > > Andrew > > > > > With powerpc-eabi I am also getting these: > > /bart/ezannoni/uberbaum/src/gdb/solib-svr4.c:857: undefined reference to `remove_solib_event_breakpoints' > /bart/ezannoni/uberbaum/src/gdb/solib-svr4.c:984: undefined reference to `create_solib_event_breakpoint' > libgdb.a(solib.o): In function `clear_solib': > /bart/ezannoni/uberbaum/src/gdb/solib.c:732: undefined reference to `disable_breakpoints_in_shlibs' > collect2: ld returned 1 exit status > > I guess it is missing the SOLIB_ADD macro definition. > Should an > #include "solib.h" be added to the config/powerpc/*.h files? Yeah, I guess so. I was trying to think of a better way to handle this, but this seems like the best solution for now. Ultimately, we'd like to *not* have ``#include "solib.h"'' in *any* config/*/{tm,nm}-*.h files. Rather, this include statement should either be placed directly in defs.h, or even better still, in just those files which require it. But to get to the point where we'll be able to do this, we'll need to convert the other files which implement solib support over to using the new mechanisms. The files which need to be converted are coff-solib.c, irix5-nat.c, pa64solib.c, somsolib.c, and xcoffsolib.c. (Thanks to Nick Duffek, osfsolib.c has already been converted. It just needs to be marked as obsolete.) Kevin