From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Buettner To: fnf@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] Fix a couple of auto-solib-add problems Date: Tue, 30 Oct 2001 17:22:00 -0000 Message-id: <1011031012211.ZM22015@ocotillo.lan> References: <200110302332.f9UNWjq31420@fishpond.ninemoons.com> X-SW-Source: 2001-10/msg00378.html On Oct 30, 4:32pm, Fred Fish wrote: > gdb/ChangeLog entry: > > 2001-10-30 Fred Fish > > * coff-solib.c (coff_solib_add): Add new readsyms arg. > * irix5-nat.c (solib_add): Ditto. > * osfsolib.c (solib_add): Ditto. > * pa64solib.c (pa64_solib_add): Ditto. > * pa64solib.c (add_to_solist): Ditto. > * pa64solib.c (read_dld_descriptor): Ditto. > * solib.c (solib_add): Ditto. > * somsolib.c (som_solib_add): Ditto. > * win32-nat.c (child_solib_add): Ditto. > * xcoffsolib.c (solib_add): Ditto. > > * coff-solib.h (coff_solib_add): Adjust prototype for new readsyms arg. > * pa64solib.c (add_to_solist): Ditto. > * pa64solib.c (read_dld_descriptor): Ditto. > * pa64solib.h (pa64_solib_add): Ditto. > * solib.h (solib_add): Ditto. > * somsolib.h (som_solib_add): Ditto. > * config/i386/tm-cygwin.h (child_solib_add): Ditto. > > * coff-solib.c (coff_solib_add): If readsyms is zero don't read > symbols but do any other needed work for shared libs. > * irix5-nat.c: Ditto. > * osfsolib.c (solib_add): Ditto. > * solib.c (solib_add): Ditto. > * win32-nat.c (child_solib_add): Ditto. > * xcoffsolib.c (solib_add): Ditto. > > * irix5-nat.c (sharedlibrary_command): Pass 1 as readsyms to > solib_add to force reading of shared library symbols. > * osfsolib.c (sharedlibrary_command;): Ditto. > * pa64solib.c (pa64_solib_sharedlibrary_command): Ditto. > * solib.c (sharedlibrary_command): Ditto. > * somsolib.c (som_solib_sharedlibrary_command): Ditto. > * xcoffsolib.c (sharedlibrary_command): Ditto. > > * coff-solib.c (coff_solib_create_inferior_hook): Call solib_add > unconditionally with auto_solib_add. > * irix5-nat.c (solib_create_inferior_hook): Ditto. > * osfsolib.c (solib_create_inferior_hook): Ditto. > * solib.c (solib_create_inferior_hook): Ditto. > * solib-osf.c (osf_solib_create_inferior_hook): Ditto. > * solib-svr4.c (enable_break): Ditto. > * solib-sunos.c (sunos_solib_create_inferior_hook): Ditto. > > * corelow.c (solib_add_stub): Add auto_solib_add to args passed > via SOLIB_ADD. > * sol-thread.c (sol_thread_attach): Ditto. > * config/rs6000/nm-rs6000.h (SOLIB_ADD): Ditto. > > * infcmd.c (attach_command): Remove auto_solib_add decl. > Call SOLIB_ADD directly with auto_solib_add. > * infrun.c (handle_inferior_event): Ditto. > > * coff-solib.h (SOLIB_ADD): Add readsyms arg. > * pa64solib.h (SOLIB_ADD): Ditto. > * solib.h (SOLIB_ADD): Ditto. > * somsolib.h (SOLIB_ADD): Ditto. > * config/i386/tm-cygwin.h (SOLIB_ADD): Ditto. > > * fork-child.c (clone_and_follow_inferior): Remove unused > auto_solib_add decl. > > * pa64solib.c (pa64_solib_add): Call add_to_solist with readsyms. > (read_dld_descriptor): Ditto. > (pa64_solib_add): Call read_dld_descriptor with readsyms. > (pa64_solib_in_dynamic_linker): Ditto. > > * corelow.c (symfile.h): Need this for auto_solib_add declaration. > * sol-thread.c (symfile.h): Ditto. > > gdb/doc/ChangeLog entry: > > 2001-10-30 Fred Fish > > * gdbint.texinfo (SOLIB_ADD): Document additional new > "readsyms" arg. Fred, Nice work. I really appreciate the descriptive text prior to the patch which explains both the problems that your patch is solving as well as your implementation strategy for solving the problems. These patches are approved to the extent that I'm able to give approval. I think I can approve your changes to these files outright: solib-osf.c solib-sunos.c solib-svr4.c solib.c solib.h config/rs6000/nm-rs6000.h The following files have "solib" in their names, but I don't feel like I really maintain them. (If I ever do maintenance on them, it'll be to move their functionality over to a solib-*.c version that I will maintain.) Nevertheless, I don't think I'm stepping on anyone's toes by granting approval for changes to these files: coff-solib.c coff-solib.h osfsolib.c (this one'll be marked obsolete soon) pa64solib.c pa64solib.h somsolib.c somsolib.h xcoffsolib.c The files below are someone else's responsibility. However, I think that we can consider changes to these files to be obvious consequences from the changes that I can give approval for. Nevertheless, I think it'd be good to wait two or three days for folks to look these changes over and raise an objection if they have problems with something that you did. After that, provided there are no objections, feel free to commit everything except for the documentation patch. config/i386/tm-cygwin.h corelow.c fork-child.c infcmd.c infrun.c irix5-nat.c sol-thread.c win32-nat.c As for the documentation patch, i.e, the changes to gdbint.texinfo, Eli Zaretskii will need to approve this change. Thanks again, Kevin