From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Buettner To: Elena Zannoni Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] xcoffread.c: remove include of partial-stab.h Date: Mon, 01 Oct 2001 15:26:00 -0000 Message-id: <1011001222537.ZM19306@ocotillo.lan> References: <15287.35303.583879.469917@krustylu.cygnus.com> <1011001210800.ZM19181@ocotillo.lan> <15288.57821.215096.623909@krustylu.cygnus.com> X-SW-Source: 2001-10/msg00021.html On Oct 1, 5:36pm, Elena Zannoni wrote: > > My only concern about this patch is with the duplication of the two > > cases in xcoffread.c. These hunks of code are of substantial size and > > it occurs to me that correct maintenance of this code may require > > keeping the various copies in sync. I'm wondering if it'd be possible > > to turn these hunks of code into functions. That way we might be able > > to avoid duplicating (some of) this code in three different places. > > > > Yes, that was the way I started thinking about this code too. But I > realized that it is probably better to completely decouple these > cases, so that a change to accomodate format A doesn't affect format B > or C. I think this common base was the reason for the 'fear' of > change in this code. By making these independent, it will become > easier to clean the code up w/o having to worry about other platforms, > that may be hard to test on (I had to dig around quite a bit to find > an AIX machine). I think the code can be simplified more this way > too, for instance we can get rid of the macro DBXREAD_ONLY, and a few > others. Okay, I agree. Kevin