Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@cygnus.com>
To: Daniel Jacobowitz <drow@mvista.com>,
	"Mike A. Harris" <mharris@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Patching gdb 5.0 for XFree86 module support
Date: Tue, 25 Sep 2001 10:52:00 -0000	[thread overview]
Message-ID: <1010925175232.ZM32001@ocotillo.lan> (raw)
In-Reply-To: <20010923134204.A31683@nevyn.them.org>

On Sep 23,  1:42pm, Daniel Jacobowitz wrote:

> > --- gdb/dbxread.c.xfree86-modules	Sat Jul  7 13:19:50 2001
> > +++ gdb/dbxread.c	Sun Sep 23 07:53:12 2001
> > @@ -2272,7 +2272,7 @@
> >  	    case 'F':
> >  	      function_stab_type = type;
> >  
> > -#ifdef SOFUN_ADDRESS_MAYBE_MISSING
> > +#if defined(SOFUN_ADDRESS_MAYBE_MISSING) || defined(XFREE_MODULE_SUPPORT)
> >  	      /* Deal with the SunPRO 3.0 compiler which omits the address
> >  	         from N_FUN symbols.  */
> >  	      if (type == N_FUN
> 
> I'm not sure that's going to fly.  SOFUN_ADDRESS_MAYBE_MISSING
> introduces its own problems; there's a good discussion in the list
> archives but I can't find it at the moment.  Of course, I can see why
> you'd need that segment.

I agree with Daniel.  I think it's going to be difficult to get the
symtab maintainers to agree to this change.

I'm curious about why it was needed in the first place though.
SOFUN_ADDRESS_MAYBE_MISSING is alread defined for Linux.  Is it
needed for some other (non-Linux) platform?

Hmm...  it just occurred to me that SOFUN_ADDRESS_MAYBE_MISSING needs
to be multiarched.  Once that's done, your problem is solved since
this could be turned on or off at will.

Kevin


  reply	other threads:[~2001-09-25 10:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-23  6:27 Mike A. Harris
2001-09-23 10:42 ` Daniel Jacobowitz
2001-09-25 10:52   ` Kevin Buettner [this message]
2001-10-03 23:45     ` Mike A. Harris
     [not found] ` <3BAEBF5A.4090209@cygnus.com>
2001-09-23 22:20   ` Mike A. Harris
2001-09-25 10:42   ` Kevin Buettner
2001-09-25 16:19     ` Mike A. Harris
2001-10-03 23:51   ` Mike A. Harris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1010925175232.ZM32001@ocotillo.lan \
    --to=kevinb@cygnus.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mharris@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox