Re: [PATCH] solib-svr4.c: Fix set_solib_svr4_fetch_link_map_offsets

Andrew Cagney
2001-09-21T18:56:00Z

> As a heads up though, one of the problems is that solib-svr4.c
> actually contains (ifdef'd) shared library support for both SVR4 and
> SunOS. I will be disentangling these mechanisms and will place SunOS
> shared library support in its own file. That way we'll be able to do
> away with the SVR4_SHARED_LIBS macro and we won't accidentally attempt
> to ever include <link.h> from solib-svr4.c any longer.

To be honest, I've been very tempted to solve this problem using a very
brutal approach: take solib-svr4.c, copy it to solib-aout.c, strip
out/in SVR4-SHARED_LIBS code, and then tweek the config files to use either.

I think this is one of those cases where the desire to re-use the code
was taken a little to far - better to get the interfaces right and have
a clear separation. Who cares about a little duplication :-)

enjoy,
Andrew