Re: [rfa/ppc/branch too] Fix PowerPC/Linux cores

Kevin Buettner
2001-08-02T12:48:00Z

On Aug 2, 12:08pm, Daniel Jacobowitz wrote:

> Fixing it "right" will be cross corefile support, but changing
> core-regset is correct for now. If no one objects I'm going to check
> in the below patch tomorrow, branch and trunk (when is the branch
> release point supposed to be? Isn't it coming up on us now?).
>
> I tested the patch on powerpc-linux, and it works exactly as expected.

Your patch looks good to me... (Please note that I'm not the maintainer
of core-regset.c though.)

> 2001-08-02 Daniel Jacobowitz <drow@mvista.com>
>
> * core-regset.c (fetch_core_registers): Remove HAVE_GREGSET_T
> and HAVE_FPREGSET_T checks. Use gdb_gregset_t and
> gdb_fpregset_t.
>
> --- gdb-5.0.cvs20010729/gdb/core-regset.c.orig Thu Aug 2 11:26:38 2001
> +++ gdb-5.0.cvs20010729/gdb/core-regset.c Thu Aug 2 11:27:05 2001
> @@ -84,9 +84,8 @@
> fetch_core_registers (char *core_reg_sect, unsigned core_reg_size, int which,
> CORE_ADDR reg_addr)
> {
> -#if defined (HAVE_GREGSET_T) && defined (HAVE_FPREGSET_T)
> - gregset_t gregset;
> - fpregset_t fpregset;
> + gdb_gregset_t gregset;
> + gdb_fpregset_t fpregset;
>
> if (which == 0)
> {
> @@ -113,7 +112,6 @@
> supply_fpregset (&fpregset);
> }
> }
> -#endif /* defined(HAVE_GREGSET_T) && defined (HAVE_FPREGSET_T) */
> }
> \f