From: Kevin Buettner <kevinb@cygnus.com>
To: Andrew Cagney <ac131313@cygnus.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH RFA] mi/mi-main.c: Don't use variable-length array extension
Date: Mon, 09 Jul 2001 09:56:00 -0000 [thread overview]
Message-ID: <1010709165551.ZM11042@ocotillo.lan> (raw)
In-Reply-To: <3B49BDD5.90803@cygnus.com>
On Jul 9, 10:21am, Andrew Cagney wrote:
> > These are probably obvious fixes, but I used alloca() which is
> > sometimes considered objectionable, so I decided to ask for approval.
> > I'm willing to rework the patch to use xmalloc(), make_cleanup(), etc,
> > but it will be messier.
> >
> > * mi-main.c (register_changed_p, get_register): Use alloca()
> > to allocate space previously allocated via gcc's
> > variable-length array extension.
>
>
> This is one of the uses of alloca that everyone has grown accustomed to.
I'll take that as approval then...
Committed.
Kevin
prev parent reply other threads:[~2001-07-09 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-08 23:28 Kevin Buettner
2001-07-09 7:21 ` Andrew Cagney
2001-07-09 9:56 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010709165551.ZM11042@ocotillo.lan \
--to=kevinb@cygnus.com \
--cc=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox