From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Buettner To: fnf@cygnus.com, gdb-patches@sourceware.cygnus.com Subject: Re: [PATCH] Fix auto-solib-add bug (patch revised again) Date: Thu, 28 Jun 2001 18:07:00 -0000 Message-id: <1010629010654.ZM12146@ocotillo.lan> References: <200009192140.OAA23805@fishpond.ninemoons.com> X-SW-Source: 2001-06/msg00493.html On Sep 19, 2:40pm, fnf@ninemoons.com wrote: > Please review and apply this patch, or let me know how it needs to be > fixed. Fred, Since your patch primarily touches solib related code, it appears that I need to review it as one of the solib maintainers. (At the time it was submitted, however, I was not a solib maintainer.) Anway... I've looked over your patch and it looks okay. I do have a question, however, regarding... > ! solib_add (args, from_tty, (struct target_ops *) 0, INT_MAX >> 22); What does ``INT_MAX >> 22'' represent? One of my concerns regarding this expression is that if INT_MAX is less than 4194304, this expression will turn out to be zero which is probably not desirable. I have not tried to apply your patch, but it seems unlikely that it'll still apply cleanly due to the changes which have occurred in GDB since the time of patch submission. If you have the time and inclination, I'd really appreciate it if you could revise it to apply cleanly against the current GDB sources. If you don't, please let me know and I'll do it... Thanks, Kevin