From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Buettner <kevinb@cygnus.com>
To: Fernando Nasser <fnasser@redhat.com>, Michael Snyder <msnyder@cygnus.com>
Cc: Kevin Buettner <kevinb@cygnus.com>, Jim Blandy <jimb@cygnus.com>, gdb-patches@sources.redhat.com, Keith Seitz <keiths@cygnus.com>
Subject: Re: [PATCH RFA] breakpoint.c: Pass breakpoint type to set_raw_breakpoint()
Date: Fri, 11 May 2001 11:35:00 -0000
Message-id: <1010511183521.ZM28626@ocotillo.lan>
References: <1010511075057.ZM27226@ocotillo.lan> <3AFC1ED7.9458AEE1@cygnus.com> <3AFC2113.5A85D353@redhat.com> <fnasser@redhat.com>
X-SW-Source: 2001-05/msg00231.html

On May 11,  1:27pm, Fernando Nasser wrote:

> > Kevin, I like it, but I noticed that set_raw_breakpoint is not static.
> > It was made extern in 1998, and is used by gdbtk-cmds.c.
> > 
> > Can you check to see if that call needs a bp_type argument, and if that
> > call can't be eliminated, maybe you should add a prototype to breakpoint.h.
> 
> I believe it can be made static now.  I don't think anyone should be
> using it outside breakpoint.c.
> 
> Keith, does your new gdbtk-bp.c uses this function?

Does Keith have a version that's not checked in yet?

I did an update a moment ago and notice that set_raw_breakpoint is
still used by gdbtk-bp.c.  Here's a telling comment from this file...

    /*
     * These are routines we need from breakpoint.c.
     * at some point make these static in breakpoint.c and move GUI code there
     */

    extern struct breakpoint *set_raw_breakpoint (struct symtab_and_line sal);
    extern void set_breakpoint_count (int);
    extern int breakpoint_count;

I will adjust the set_raw_breakpoint() calls in gdbtk-bp.c to pass the
extra argument.  I'll let Keith (or someone else more familiar with
these issues than I am) decide whether a prototype ought to be added
to breakpoint.h or if the calls in gdbtk-bp.c can be eliminated (thus
allowing breakpoint.c to make set_raw_breakpoint() static again).

Kevin