From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Buettner To: Nicholas Duffek , gdb-patches@sourceware.cygnus.com Cc: ezannoni@cygnus.com, phdm@macqel.be, kevinb@cygnus.com, Peter.Schauer@regent.e-technik.tu-muenchen.de, jimb@cygnus.com Subject: Re: [RFA] patch to skip bigtoc fixup code Date: Tue, 01 May 2001 08:07:00 -0000 Message-id: <1010501150355.ZM588@ocotillo.lan> References: <200104301626.MAA00208@nog.bosbc.com> X-SW-Source: 2001-05/msg00003.html On Apr 30, 12:26pm, Nicholas Duffek wrote: > * config/rs6000/tm-rs6000.h (IN_SOLIB_RETURN_TRAMPOLINE): Define. > (rs6000_in_solib_return_trampoline): Declare. > * rs6000-tdep.c (rs6000_in_solib_return_trampoline): New > function. > (rs6000_skip_trampoline_code): Skip bigtoc fixup code. > * xcoffread.c (read_xcoff_symtab): Perform the ISFCN function > check after the CSECT check rather than before it. Allocate > separate symtabs for CSECTs whose names begin with '@'. > (scan_xcoff_symtab): Don't ignore symbols beginning with '@'. > Activate the misc_func_recorded mechanism for whose names begin > with '@'. > > Tested on powerpc-ibm-aix4.3.3.0. Okay to apply? Nick, It all looks okay to me. The tm-rs6000.h and rs6000-tdep.c changes are approved. (Actually, I'm not sure you need my approval, since it looks to me like you're a co-maintainer of these files.) I'm going to defer to the others regarding xcoffread.c since I apparently stepped on a few toes the last time... I will note, however, that IN_SOLIB_RETURN_TRAMPOLINE ought to be multiarched at some point, but I see no reason to hold up this patch since you're merely making use of an existing macro that hasn't yet been multiarched. Kevin