From: Kevin Buettner <kevinb@cygnus.com>
To: Eli Zaretskii <eliz@is.elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH RFC] abort() to internal_error()
Date: Wed, 21 Feb 2001 07:54:00 -0000 [thread overview]
Message-ID: <1010221155405.ZM28354@ocotillo.lan> (raw)
In-Reply-To: <Pine.SUN.3.91.1010221120010.18287S@is>
On Feb 21, 12:04pm, Eli Zaretskii wrote:
> On Tue, 20 Feb 2001, Kevin Buettner wrote:
>
> > * monitor.c (monitor_printf_noecho, monitor_printf,
> > monitor_dump_regs): Likewise.
>
> This is not how ChangeLog entries should span several lines; see
> standards.texi. This style gets in the way of font-lock in Emacs, for
> starters. It should be formatted like so:
>
> * monitor.c (monitor_printf_noecho, monitor_printf)
> (monitor_dump_regs): Likewise.
Right you are. Thanks for spotting this; I've been doing it wrong
for a while now.
Assuming no other problems are found, here are the entries that I
will eventually commit...
* buildsym.c (push_subfile, pop_subfile): Replace call to abort()
with call to internal_error().
* dbxread.c (process_one_symbol): Likewise.
* exec.c (build_section_table, xfer_memory): Likewise.
* h8500-tdep.c (h8500_register_size, h8500_register_virtual_type):
Likewise.
* hpread.c (hpread_type_translate, hpread_read_array_type)
(hpread_type_lookup): Likewise.
* i386-tdep.c (gdb_print_insn_i386): Likewise.
* i960-tdep.c (mem): Likewise
* inflow.c (set_sigio_trap, clear_sigio_trap): Likewise.
* infptrace.c (child_resume): Likewise.
* infttrace.c (_initialize_infttrace): Likewise.
* language.c (binop_result_type, add_language): Likewise.
* lynx-nat.c (store_inferior_registers): Likewise.
* m3-nat.c (port_chain_insert, m3_trace_me): Likewise.
* mdebugread.c (parse_partial_symbols): Likewise.
* monitor.c (monitor_printf_noecho, monitor_printf)
(monitor_dump_regs): Likewise.
* ocd.c (stu_put_packet): Likewise.
* printcmd.c (decode_format, print_scalar_formatted): Likewise.
* remote-bug.c (bug_open): Likewise.
* remote-e7000.c (fetch_regs_from_dump, e7000_wait): Likewise.
* remote-es.c (es1800_read_bytes): Likewise.
* remote-mips.c (common_breakpoint): Likewise.
* remote-rdp.c (send_rdp): Likewise.
* remote-sds.c (putmessage): Likewise.
* sparc-nat.c (fetch_inferior_registers, store_inferior_registers):
Likewise.
* sparcl-tdep.c (sparclite_download): Likewise.
* symtab.c (lookup_partial_symbol): Likewise.
* target.c (push_target, pop_target, initialize_targets): Likewise.
* utils.c (internal_verror, malloc_botch, wrap_here, decimal2str):
Likewise.
* valprint.c (print_decimal, print_longest, print_longest)
(strcat_longest): Likewise.
* w65-tdep.c (init_frame_pc, w65_push_dummy_frame): Likewise.
* xmodem.c (xmodem_send_packet): Likewise.
* z8k-tdep.c (init_frame_pc, z8k_push_dummy_frame): Likewise.
* config/h8500/tm-h8500.h (STORE_STRUCT_RETURN): Likewise.
* config/mn10200/tm-mn10200.h (EXTRACT_RETURN_VALUE,
STORE_RETURN_VALUE): Likewise.
* config/ns32k/nm-umax.h (REGISTER_U_ADDR): Likewise.
* config/ns32k/xm-merlin.h (REGISTER_U_ADDR): Likewise.
* config/z8k/tm-z8k.h (STORE_STRUCT_RETURN, STORE_RETURN_VALUE):
Likewise.
next prev parent reply other threads:[~2001-02-21 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-20 22:51 Kevin Buettner
2001-02-20 23:14 ` Kevin Buettner
2001-02-21 2:07 ` Eli Zaretskii
2001-02-21 7:54 ` Kevin Buettner [this message]
2001-02-21 8:03 ` Eli Zaretskii
2001-02-21 8:46 ` Kevin Buettner
2001-02-21 9:09 ` Eli Zaretskii
2001-02-24 20:46 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1010221155405.ZM28354@ocotillo.lan \
--to=kevinb@cygnus.com \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox