Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@cygnus.com>
To: "Martin M. Hunt" <hunt@redhat.com>, <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] info_sharedlibrary_command patch
Date: Mon, 19 Feb 2001 18:35:00 -0000	[thread overview]
Message-ID: <1010220023548.ZM24397@ocotillo.lan> (raw)
In-Reply-To: <Pine.SUN.4.33.0102191649590.2670-100000@rtl.cygnus.com>

On Feb 19,  4:52pm, Martin M. Hunt wrote:

> info_sharedlibrary_command() currently casts all addresses to long before
> printing them.  Obviously this fails if pointers are larger than longs.
> 
> 2001-02-19  Martin M. Hunt  <hunt@redhat.com>
> 
> 	* solib.c (info_sharedlibrary_command): Don't assume pointers
> 	are the same size of long, call	longest_local_hex_string_custom().

Approved.

I was looking at this one myself a while back, but got bogged down on
whether to use longest_local_hex_string_custom() or paddr().  See
http://sources.redhat.com/ml/gdb/2000-10/msg00090.html .  For now, your
change is fine.

Kevin


      reply	other threads:[~2001-02-19 18:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-19 16:52 Martin M. Hunt
2001-02-19 18:35 ` Kevin Buettner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1010220023548.ZM24397@ocotillo.lan \
    --to=kevinb@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=hunt@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox