From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Buettner <kevinb@cygnus.com>
To: Michael Snyder <msnyder@cygnus.com>, gdb-patches@sources.redhat.com
Cc: keiths@redhat.com, kevinb@redhat.com
Subject: Re: [RFC] Accomodate 64-bit msymbols in expressions
Date: Fri, 16 Feb 2001 16:31:00 -0000
Message-id: <1010217003055.ZM12822@ocotillo.lan>
References: <3A8DBFEF.45B230C1@cygnus.com> <msnyder@cygnus.com>
X-SW-Source: 2001-02/msg00318.html

On Feb 16,  4:03pm, Michael Snyder wrote:

> The following change is motivated by the fact that the addresses of
> minimal symbols currently get truncated to 32 bits in expressions.
> 
> Does this look badly wrong to anybody?

Not badly wrong.  The only nit that I can pick is...

> !   /* Let's make the type big enough to hold a 64-bit address.  */
> !   write_exp_elt_type (builtin_type_long_long);

...that it might be preferable to use builtin_type_CORE_ADDR instead.

(I.e, think about what happens if TARGET_LONG_LONG_BIT == 32, but
TARGET_ADDR_BIT == 64.)

Kevin