From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NZd6G6Fk32ld7BgAWB0awg (envelope-from ) for ; Wed, 15 Apr 2026 06:12:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QtrKYT8h; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=d/TS49Ze; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t0y0DtP6; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eYs/QWFq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5DAB21E0B1; Wed, 15 Apr 2026 06:12:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 76DCF1E0B1 for ; Wed, 15 Apr 2026 06:12:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 878754BA2E23 for ; Wed, 15 Apr 2026 10:12:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 878754BA2E23 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=QtrKYT8h; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=d/TS49Ze; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=t0y0DtP6; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eYs/QWFq Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 283CC4BA5436 for ; Wed, 15 Apr 2026 10:12:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 283CC4BA5436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 283CC4BA5436 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776247942; cv=none; b=YQW0aj7WSN78zP43EhWl/WBG/VgpWbVdPlURfc54b/YWPFI9HvdGcDelglLyo3+zdk1at4R8m7w+ctMllQqd2fYMZGBbkoK2C53ariD4lydxP3Qyxnvbg1NRDvKHT4Ms/Yi4xkNFLVoDKZ7usn71fzT7rz3VN48nPMJYaSVAUTQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776247942; c=relaxed/simple; bh=ZF1cGhpVn5ImdbZydfC4b3bf58MXeWYJ64CXlA5Rpio=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=q6UVgwGqUkyw/35PBdvIg1L+6etKBESfTzdMKHZUz2QHEWzmbJYTwWRUsp+yzFSeWWI8QeVNlHprMDBzAmafrwW0f9H+fk+7VtX1OwkFJWMCu+ALgjvsquJzfXlDv9SQjMl7WoI/lp0nUA7v38tFAsGvr6b1Y54BGO5Kn97tEK8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 283CC4BA5436 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E52F85BCF7; Wed, 15 Apr 2026 10:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776247941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xcc31hUirEhV3rt5qKUnnEebo2ZNIQv4Zo8BeoOa7ig=; b=QtrKYT8hiSBshsRYoa0QKlawpCNKbrbTKdmXzDlCB5+wZoKJ3aXkfcD0mJrKsmLIfr3rz/ aSIIb+mblhb/w8oFwoDKBHONx3lzhI5oJyoA1952VC22EWt0Z1ySgqtwT1RQ5vWO11vZUZ wtsZlj7sBmVx+Ef3Sbc+F4qh0GZn7ig= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776247941; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xcc31hUirEhV3rt5qKUnnEebo2ZNIQv4Zo8BeoOa7ig=; b=d/TS49Ze3eiX1MfUXZHI6E+3U3/h6gHj9HHjaekrSJpHZgdostePSPsiHuf9IYBioba4RF /fe0afOX0J+774Cg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=t0y0DtP6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="eYs/QWFq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776247940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xcc31hUirEhV3rt5qKUnnEebo2ZNIQv4Zo8BeoOa7ig=; b=t0y0DtP6KcgJ5qtpep6E+Nb2NHUugVbijuubi1LT8c/r24uqfexKcoxdPBv4OUgnHJGycP ihN4ppbT1+MgQ6CPMj5IdoSYN90qali3ZmTEyyNLYdvai97i59akxXrDSXHtxleAwBnTPp kQuusNHJ3QKwBrA+h4Va7cgrd65NaSI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776247940; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xcc31hUirEhV3rt5qKUnnEebo2ZNIQv4Zo8BeoOa7ig=; b=eYs/QWFqJW7MuiwhZ8PRUauIK0D12mwtV5WMenyFzXZHIUZfS8coAtsMWairARZCBFQduX PZiA90K/b2RjNTBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C78C44B95D; Wed, 15 Apr 2026 10:12:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 9datLoRk32myIQAAD6G6ig (envelope-from ); Wed, 15 Apr 2026 10:12:20 +0000 Message-ID: <0ffc110b-1475-43fc-b5f8-6ce4fc2e8d73@suse.de> Date: Wed, 15 Apr 2026 12:12:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] [gdb/exp] Fix ignoring of incorrect namespace prefix To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260410121144.1836026-1-tdevries@suse.de> <20260410121144.1836026-3-tdevries@suse.de> <87fr4xv1o3.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87fr4xv1o3.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; ARC_NA(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[sourceware.org:url, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns, suse.de:dkim, suse.de:mid, suse.de:email] X-Rspamd-Queue-Id: E52F85BCF7 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/14/26 8:26 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> @@ -431,7 +431,14 @@ cp_lookup_symbol_via_imports (const char *scope, > > I find this function and related functions pretty hard to follow, so I'm > not really sure about the bug or the patch, but: > > Tom> + const char *current_scope = (block->function () != nullptr > Tom> + ? block->scope () > Tom> + : nullptr /* Don't know. */); > > ... this line struck me as a bit weird, in that block->function() isn't > set for all blocks inside a function, so this would mean that stepping > into some nested block would seem to reproduce the bug again. Hi Tom, thanks for the review. I've extended the test-case with the nested block scenario you describe, and indeed the bug reproduced again. I've fixed that by checking for "block->function_block () != nullptr" instead. V4 submitted here ( https://sourceware.org/pipermail/gdb-patches/2026-April/226488.html ). Thanks, - Tom