From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57102 invoked by alias); 8 Jun 2017 09:55:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55894 invoked by uid 89); 8 Jun 2017 09:55:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1289 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jun 2017 09:55:04 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E05737EE1; Thu, 8 Jun 2017 09:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 3E05737EE1 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 3E05737EE1 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3AC78B748; Thu, 8 Jun 2017 09:55:05 +0000 (UTC) Subject: Re: [PATCH] Remove MAX_REGISTER_SIZE from mi/mi-main.c To: Alan Hayward , "gdb-patches@sourceware.org" References: <4AA96E9D-7905-4D03-9424-2BC71D117CE2@arm.com> Cc: nd From: Pedro Alves Message-ID: <0fd04925-3200-53b9-5a7d-904ea028c3b0@redhat.com> Date: Thu, 08 Jun 2017 09:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <4AA96E9D-7905-4D03-9424-2BC71D117CE2@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00207.txt.bz2 On 06/08/2017 10:42 AM, Alan Hayward wrote: > /* Get register contents and compare. */ > - prev_status = regcache_cooked_read (prev_regs, regnum, prev_buffer); > - this_status = regcache_cooked_read (this_regs, regnum, this_buffer); > - > - if (this_status != prev_status) > - return 1; > - else if (this_status == REG_VALID) > - return memcmp (prev_buffer, this_buffer, > - register_size (gdbarch, regnum)) != 0; > + prev_value = prev_regs->cooked_read_value (regnum); > + this_value = this_regs->cooked_read_value (regnum); > + gdb_assert (prev_value != NULL); > + gdb_assert (this_value != NULL); > + > + if (value_optimized_out (prev_value) != value_optimized_out (this_value) > + || value_entirely_available (prev_value) > + != value_entirely_available (this_value)) > + ret = 1; > + if (value_optimized_out (prev_value) > + || !value_entirely_available (prev_value)) > + ret = 0; > else > - return 0; > + ret = memcmp (value_contents_all (prev_value), > + value_contents_all (this_value), > + register_size (gdbarch, regnum)) != 0; > + > + release_value (prev_value); > + release_value (this_value); > + value_free (prev_value); > + value_free (this_value); > + return ret; > } > Use value_contents_eq? Thanks, Pedro Alves