From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9406 invoked by alias); 27 Jun 2017 19:48:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9339 invoked by uid 89); 27 Jun 2017 19:48:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,GIT_PATCH_2,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Jun 2017 19:48:48 +0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v5RJmf2B022456 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jun 2017 19:48:42 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v5RJmf0K007487 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Jun 2017 19:48:41 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v5RJmd3k015502; Tue, 27 Jun 2017 19:48:39 GMT MIME-Version: 1.0 Message-ID: <0fba9f61-0921-490a-8406-efe8cd0d90e3@default> Date: Tue, 27 Jun 2017 19:48:00 -0000 From: Weimin Pan To: Cc: Subject: Re: [PATCH v3] gdb: ADI support Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-SW-Source: 2017-06/txt/msg00749.txt.bz2 Thanks for your comments. I have (1) moved the "NEWS" entry from gdb/doc/ChangeLog to gdb/ChangeLog. (2) changed gdb.texinfo as follows: @table @code @kindex adi examine @item adi (examine | x) [ / @var{n} ] @var{addr} The @code{adi examine} command displays the value of one ADI version tag per cacheline. It has the following command syntax: @var{n} is a decimal integer specifying the number in bytes; the default=20 is 1. It specifies how much ADI version information, at the ratio of 1:ADI= =20 block size, to display. @var{addr} is the address in user address space where you want @value{GDBN} to begin displaying the ADI version tags. ... ... ----@kindex adi assign @item adi (assign | a) [ / @var{n} ] @var{addr} =3D @var{tag} The @code{adi assign} command is used to assign new ADI version tag to an address. It has the following command syntax: @var{n} is a decimal integer specifying the number in bytes; the default is 1. It specifies how much ADI version information, at the ratio of 1:ADI block size, to modify. @var{addr} is the address in user address space where you want @value{GDBN} to begin modifying the ADI version tags. @var{tag} is the new ADI version tag. - Original Message ----- From: eliz@gnu.org To: weimin.pan@oracle.com Cc: gdb-patches@sourceware.org Sent: Tuesday, June 27, 2017 7:36:28 AM GMT -08:00 US/Canada Pacific Subject: Re: [PATCH v3] gdb: ADI support > From: Weimin Pan > Date: Mon, 26 Jun 2017 19:12:46 -0500 >=20 > gdb/doc/ChangeLog: > 2017-06-26 Weimin Pan > * gdb.texinfo (Architectures): Add new Sparc64 section to document > ADI support. > * NEWS: Add "adi examine" and "adi assign" commands. I don't see the NEWS part in the patch. And NERWS is not in gdb/doc/, so its ChangeLog entry should be in gdb/ChangeLog. > +The @code{adi examine} command displays the value of one ADI version tag= per=20 > +cacheline. It has the following command syntax:=20 > + > +@table @code > +@itemx adi (examine | x) [ / @var{n} ] @var{addr} > +@end table This should be @example, not @itemx in @table. Alternatively, put all the arguments on the previous @item line -- that's how we usually describe commands in the first place. > +@var{n}, the byte count > +The count is a decimal integer specifying the number in bytes; the defau= lt=20 > +is 1. The first part should be part of the sentence: The count @var{n} is a decimal integer specifying ... > +@var{addr}, starting display address > +@var{addr} is the address in user address space where you want @value{GD= BN}=20 > +to begin displaying the ADI version tags.=20 Here the part before the sentence should be simply deleted, as it isn't needed. > +@kindex adi assign > +@item adi assign > + > +The @code{adi assign} command is used to assign new ADI version tag=20 > +to an address. It has the following command syntax: > + > +@table @code > +@itemx adi (assign | a) [ / @var{n} ] @var{addr} =3D @var{tag} > +@end table > + > +@var{n}, the byte count > +The count is a decimal integer specifying the number in bytes; the defau= lt=20 > +is 1. It specifies how much ADI version information, at the ratio of 1:= ADI=20 > +block size, to modify.=20 > + > +@var{addr}, starting display address > +@var{addr} is the address in user address space where you want @value{GD= BN}=20 > +to begin modifying the ADI version tags.=20 > + > +@var{tag}, the new ADI version tag Same comments to the description of this command. Thanks.