From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ec0kJs9IPWrv+xcAWB0awg (envelope-from ) for ; Thu, 25 Jun 2026 11:27:11 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G+qjNWG7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 963D81E0A6; Thu, 25 Jun 2026 11:27:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BE1A91E024 for ; Thu, 25 Jun 2026 11:27:10 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 587394BA23E7 for ; Thu, 25 Jun 2026 15:27:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 587394BA23E7 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G+qjNWG7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 34DF24BA2E3B for ; Thu, 25 Jun 2026 15:26:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34DF24BA2E3B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34DF24BA2E3B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782401194; cv=none; b=AgBIRqC6Ieu+1hJ3XTif/imEBBCFeGh0PMsT6HiS5IOdzXkZulsdixr6uHEm2PiGnairJ5nmgqnJ6BQ5i2ATAKvNHyz4+ewZMY2YVCL03vX2DKlOetiJtOTIpDb7Wxp1mskkCbN7jB+Po8ZH528dtrlyyAVfpK2hwz3op29Ou2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782401194; c=relaxed/simple; bh=7KbwyrzId5VYBv2EdA1WQEdeHSCSPxyDjvLAJ3BSFBc=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=jkbAAI0rrbp4Zr/cXKVedyjWhWwxytx+QPls/bV2kUarTcvPj9P8kroSjXf/ywE5v03fi1KGJQO+fb52J6T0+LR03eJa5/EunpwFzXWIR4PAiDafSYshXLAoU+Mv+PURTdpuXUtKtFlWhHgaevs2Ellp8wgWVB1vKk5c3GnNLV8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=G+qjNWG7 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 34DF24BA2E3B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782401193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rLat32RNcLZ9IL3YYhv79dFILnly0vhJ0cJeRpybIBs=; b=G+qjNWG7ZS6n15VKRIpnxulHvBYe43mXvZ89SAVW2FzZvNvtu89l1eGlnRBOowq45ZRkxG iuK7S/VIxv/tpVytq/zjNS2yNxKmBa2FcLukzPlcZtqgS3KWioPSaNDoNw2W50VD6rTqRZ ZDaLSIKNxJPw8AN5MCfAx4LLOiF4mfI= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-348-Bd-We1xHMhWtFROSPkzfjA-1; Thu, 25 Jun 2026 11:26:32 -0400 X-MC-Unique: Bd-We1xHMhWtFROSPkzfjA-1 X-Mimecast-MFC-AGG-ID: Bd-We1xHMhWtFROSPkzfjA_1782401191 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4629f312a67so2585695f8f.2 for ; Thu, 25 Jun 2026 08:26:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782401191; x=1783005991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rLat32RNcLZ9IL3YYhv79dFILnly0vhJ0cJeRpybIBs=; b=Fj1GXOXwdv2bkFa9GwNByked53EOPyH5/qvOMipqgeKZKzrWtBNgGRwsBvgXDq8Mbr VY3XtqkMweR5OCFUuXswOATRw2PhscNfeEOK1sc8Cmw3HNsaNtTqIh7NJjCROjq1h/dE jOcl1UIKefl5EfPFZcLfei0n988A4PLgGms62+tDHE9vXIxhtrMRQpRuKLCJOB8f2HHn u/mrJ395BrBKjdcEkLsaeIvcddmhCsyPv9Kw2iHmfVanER3lcBzg1QqnAV3B3E1CJgq9 +tHu9yKaRqyIcvt/+oiB+FEvWxFG4Kt0pefMyQtsb6w7nrD/tYtkkKzm6cR2sd6YG9WH qUWA== X-Gm-Message-State: AOJu0YxNgew900xAa0vez7WZH7q9Uz8aVB8peLcOeA9/Uf4C89b6pEkc 9NCjVhjimogz8xVOq3YStF2/VwSycRHac+qGYaxy5gkIuV6O0FQ/uAVdB8aQQLEwNcEmNZQxaUe h2omOSs2Nb8IcKqWVafpcmikYkuQu5o+bbMXoIwqG5rIboQYxbzJEEm4wmLdqc5waQwQu584uIR MV0uGSywTvhPEfkDB43bMTh3ipjbGB/Sa1Z++gq5odCtEdQAQ= X-Gm-Gg: AfdE7cn3a/a5t9M0Qyd7OtpEnByoasVirmLl5dxBPBYZLu//hy8BWE7J+GkImAYGGMn 9bFslamqEzuK/obFcYrvCcXpH8AhpPwTFL8xW9R2Y+t4PVWINPCPVo3oW+mNJOw3DwCaO9asIPN L6wgoYtKkICjTnCjQFt5yMlv91AcKBGIA7ABaFmiALMsj2wzAx4mogKECtHiYRb2KgtMoMYLjlR 3SXuDM2ic+7dMrBtbUFjSjDPxgrNHRjfrU/bGdk14jdJScMtcjC04wF+IYaq0PuaWnfVj1zYtY1 6kuz7upi0v6r57moZrFrIrPBOuZrF9dYUh9wQEg5N+GeNAtFWcYwetjbKeHvBBUTVXkS4rPTMka P8NfilvbO9iE5DTFNNAtxn/9nvsOdqg== X-Received: by 2002:a05:600c:4712:b0:492:5e21:458b with SMTP id 5b1f17b1804b1-4926683236dmr42637975e9.8.1782401191240; Thu, 25 Jun 2026 08:26:31 -0700 (PDT) X-Received: by 2002:a05:600c:4712:b0:492:5e21:458b with SMTP id 5b1f17b1804b1-4926683236dmr42637315e9.8.1782401190607; Thu, 25 Jun 2026 08:26:30 -0700 (PDT) Received: from localhost (19.81.93.209.dyn.plus.net. [209.93.81.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4926531b9aesm70547115e9.1.2026.06.25.08.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2026 08:26:29 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Andrew Burgess , Pedro Alves Subject: [PATCHv5 4/4] gdb: cache program space entry point information Date: Thu, 25 Jun 2026 16:26:21 +0100 Message-Id: <0fb565691512b5ac618d4e1d7151a21339ef6c06.1782401095.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: x-WQfKPdJMzo-3SjzoGl4j3y89R8AQg3mNFgY5gzxCA_1782401191 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org After the previous two patches, every time that GDB unwinds a frame there are now two places where we check if the frame is an entry point frame, these are in get_prev_frame and get_prev_frame_always, look for the calls to `inside_entry_func`, which then calls program_space::get_entry_point_info. The calls to program_space::get_entry_point_info are not crazy expensive, but they are not free either, there are reads from target memory to read the auxv vector and the entry address offset, so on remote targets this could introduce a small delay, especially as this occurs twice per frame now. However, the information returned by program_space::get_entry_point_info is not expected to change from one call to the next. This information should be a property of the executable and libraries, so we really only need to figure it out once. This commit caches the entry point information within program_space, clearing it whenever an inferior starts or exits, or whenever the executable is updated. After clearing GDB will compute, and cache the updated information the next time it is needed, which will be whenever GDB needs to unwind a frame. It will be possible to observe this change by, for example, monitoring the remote target packets, but as far as the normal GDB output is concerned, there should be no user visible changes after this commit. --- gdb/progspace.c | 34 +++++++++++++++++++++++++++++++--- gdb/progspace.h | 9 ++++++++- 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/gdb/progspace.c b/gdb/progspace.c index 26e16cae8d0..c1f3044f4c5 100644 --- a/gdb/progspace.c +++ b/gdb/progspace.c @@ -289,9 +289,12 @@ program_space::exec_entry_point_address () const /* See progspace.h. */ -program_space::entry_point_info +const program_space::entry_point_info & program_space::get_entry_point_info () const { + if (m_entry_point_info.has_value ()) + return m_entry_point_info.value (); + std::optional exec_entry_address = this->exec_entry_point_address_if_available (); @@ -299,8 +302,9 @@ program_space::get_entry_point_info () const if (m_solib_ops != nullptr) inferior_entry_address = m_solib_ops->inferior_entry_point_address (); - return entry_point_info (std::move (inferior_entry_address), - std::move (exec_entry_address)); + m_entry_point_info.emplace (std::move (inferior_entry_address), + std::move (exec_entry_address)); + return m_entry_point_info.value (); } /* Implement the 'maint info entry-address' command. */ @@ -538,11 +542,35 @@ program_space::clear_solib_cache () deleted_solibs.clear (); } +/* Clear cached entry point information in the program space of INF. */ + +static void +clear_cached_entry_point_info_for_inferior (inferior *inf) +{ + inf->pspace->clear_cached_entry_point_info (); +} + +/* Clear cached entry point information in the program space PSPACE. */ + +static void +clear_cached_entry_point_info_for_pspace (program_space *pspace, + bool /* reload */) +{ + pspace->clear_cached_entry_point_info (); +} + /* See progspace.h. */ void initialize_progspace () { + gdb::observers::inferior_created.attach + (clear_cached_entry_point_info_for_inferior, "program-space"); + gdb::observers::inferior_exit.attach + (clear_cached_entry_point_info_for_inferior, "program-space"); + gdb::observers::executable_changed.attach + (clear_cached_entry_point_info_for_pspace, "program-space"); + add_cmd ("program-spaces", class_maintenance, maintenance_info_program_spaces_command, _("Info about currently known program spaces."), diff --git a/gdb/progspace.h b/gdb/progspace.h index d75379fe621..407d2595136 100644 --- a/gdb/progspace.h +++ b/gdb/progspace.h @@ -369,7 +369,11 @@ struct program_space /* Return information about the entry point in the main executable, and the entry point for the inferior, which might be different from the main executable. */ - entry_point_info get_entry_point_info () const; + const entry_point_info &get_entry_point_info () const; + + /* Clear any cached entry point information. */ + void clear_cached_entry_point_info () + { m_entry_point_info.reset (); } /* If there is a valid and known entry point in the main executable of this program space, return it. Otherwise return an empty optional. */ @@ -462,6 +466,9 @@ struct program_space /* See `exec_filename`. */ gdb::unique_xmalloc_ptr m_exec_filename; + + /* Cached entry point information. See get_entry_point_info. */ + mutable std::optional m_entry_point_info; }; /* The list of all program spaces. There's always at least one. */ -- 2.25.4