From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MCfoGqjx5mcJyx0AWB0awg (envelope-from ) for ; Fri, 28 Mar 2025 14:59:52 -0400 Received: by simark.ca (Postfix, from userid 112) id 6C63C1E0C3; Fri, 28 Mar 2025 14:59:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2857A1E0C0 for ; Fri, 28 Mar 2025 14:59:52 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D1FD13857BA5 for ; Fri, 28 Mar 2025 18:59:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D1FD13857BA5 Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 431B83830604 for ; Fri, 28 Mar 2025 18:59:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 431B83830604 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 431B83830604 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743188359; cv=none; b=r2CJ1j61bPAMlIFNb52gd/CxZVxb3Y4NcPnvvzJ0lHbrcoukcvp8+ANgw4JrjdUVG3gHdvlBvDW+Gn/BadFF+E4pAKm/IpearJsRgBNZ3iNGRvievLZ7rwg7Hogbbgmd5AlsYeryUBUUla6g172TbDIvx1rZHSI8520TNJddGcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1743188359; c=relaxed/simple; bh=ZDkkUHH7co8S3lX5Ugxo333JILIfYnGn74eSnQ0vTIY=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=bODhNfFxacqsKujh6bCzS0xNZQr4Y44+mYlZmsLuq2NcuXep+bkxSzF6I/Cjkvtdo0RIjfS24/GQAbpts9BT4+sWoJ+rCEn05OBQ6Vt1+RcHdXReygMAUGpPpREBC3XToKh0NdHpRJ6GAOUeflRpGMnY3AeZDZdww+w+U1wBqY0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 431B83830604 Received: from mop.. (unknown [82.8.138.118]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sam@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id D4E7734313A; Fri, 28 Mar 2025 18:59:17 +0000 (UTC) From: Sam James To: gdb-patches@sourceware.org Cc: Simon Marchi , Sam James Subject: [PATCH 2/2] gdb-add-index: fix shellcheck warnings Date: Fri, 28 Mar 2025 18:58:52 +0000 Message-ID: <0fa2e0d207eef78dc6a4305ee28588676932753e.1743188332.git.sam@gentoo.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org * Drop useless echo * Add missing quoting to rm argument (and use -- to delimit options) * Fix quoting w/ trap to avoid expanding $tmp_files immediately --- gdb/contrib/gdb-add-index.sh | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh index b299f830373..f727d28aac7 100755 --- a/gdb/contrib/gdb-add-index.sh +++ b/gdb/contrib/gdb-add-index.sh @@ -2,7 +2,7 @@ # Add a .gdb_index section to a file. -# Copyright (C) 2010-2024 Free Software Foundation, Inc. +# Copyright (C) 2010-2025 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 3 of the License, or @@ -136,7 +136,6 @@ if $READELF -S "$file" | grep -q " \.gnu_debugaltlink "; then | grep -A1 "'\.gnu_debugaltlink':" \ | tail -n +2 \ | sed 's/.*]//') - dwz_file=$(echo $dwz_file) if $READELF -S "$dwz_file" | grep -E -q " \.(gdb_index|debug_names) "; then # Already has an index, skip it. dwz_file="" @@ -163,10 +162,10 @@ for f in "$file" "$dwz_file"; do tmp_files="$tmp_files $index4 $index5 $debugstr $debugstrmerge $debugstrerr" done -rm -f $tmp_files +rm -f -- "$tmp_files" # Ensure intermediate index file is removed when we exit. -trap "rm -f $tmp_files" 0 +trap 'rm -f $tmp_files' 0 $GDB --batch -nx -iex 'set auto-load no' \ -iex 'set debuginfod enabled off' \ -- 2.49.0