From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KMmYLnZLTWrrWysAWB0awg (envelope-from ) for ; Tue, 07 Jul 2026 14:54:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=O1R3M8U4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A8B201E098; Tue, 07 Jul 2026 14:54:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A8F721E024 for ; Tue, 07 Jul 2026 14:54:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5DB184BA2E3D for ; Tue, 7 Jul 2026 18:54:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5DB184BA2E3D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=O1R3M8U4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 9D06E4BA2E1B for ; Tue, 7 Jul 2026 18:54:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9D06E4BA2E1B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9D06E4BA2E1B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783450460; cv=none; b=h818PaKiqLQ/A8ZdBlAl0IqCdS0O50hGAF3ZvAxtBYwbAPiVm2BWK/uR9OIUw7McqDo0yR9nlqF7xUjJH5bBSd5PXJf6Q8a+hAktQSL3yOx82EvYKtg2GEorjWrGCQX2TR4YS/GqfhDYLcypCdg2EeS1avr4qzjEl+u0+eNRDZs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783450460; c=relaxed/simple; bh=3kbucWmGJqFXWyIZePxuGZ7JSq0v+iI38oa6XdNWkIo=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=H+5vwdgr66uisuRTU3vcRaR3YY0hTAeupQnlzpBdUV9jXNyhRy73wleLd9ZLVjFjDNnMESBa/jph4OWsjEfQaweBKuACz7gog4MEtGXA8cAyfiwGevaCj0Jc/S/jsrRuI/wGtzBVngYt7FrPyacPZtLSi4w6t+1DB/2lDJYnWc4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=O1R3M8U4 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D06E4BA2E1B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783450460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VPIeE2/bMqkkswXH3jxDJtMD03p72C9Od6ODC+PkZ5E=; b=O1R3M8U4s4ktrnBDJzmpY9bumk9qT15wUYppPYYsDUc/e1z623KIN3dwXAwq9KQO/g3Aat FDOsp61p4xWON1FEiTUSRCAq42cioUe9L0pWvuv3OT2glqHHw3lCn5KZXAvTRsOyCIIXOu qsIka85WsZd/1TtbiTqP35iCHxaX40o= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-279-F1rHEu2LMduiWdTa9zqJtA-1; Tue, 07 Jul 2026 14:54:18 -0400 X-MC-Unique: F1rHEu2LMduiWdTa9zqJtA-1 X-Mimecast-MFC-AGG-ID: F1rHEu2LMduiWdTa9zqJtA_1783450458 Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-847b8d76e3dso7506287b3a.1 for ; Tue, 07 Jul 2026 11:54:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783450458; x=1784055258; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VPIeE2/bMqkkswXH3jxDJtMD03p72C9Od6ODC+PkZ5E=; b=AoCjCA2nzO8+mUBsoi+RWEbs+qzMxcWzqsKxpLEiLv4RWxofdc+71QohTblT+j03Am Zg3KxBPrpGccGYL4jOuJZlVzdZIxIsIKxIZ6bR/yjP+nR4b0yJX4yqjT6cDQwn9BabpZ ZMm4q7JDVf38Y1FRD7Qt2EKURwTU4LC6EmFIu1xUZghRBYjAlPCoFoZesVP94jTjbaSl ddWp+xu/4COV6rHXHHO6wBIG1U3R2YbgDXYgZCQlOgO+/hT1Xc0oNBdhVPZz6r8hUSnK cQ8UrQ/Ik2LjRGfToY/mQonz8UQYzs92qxPmJtDSJc+3f03/TyYllFh6wSq0CH2us5PJ v1wQ== X-Forwarded-Encrypted: i=1; AHgh+RrAdiBu7/Cf4SyAx6Hw7z1ByDEWbt8BwPfHGkUZW9+djAUkPf22XEWxXHoIajtCtrxoE9bo2PaYDq9R9Q==@sourceware.org X-Gm-Message-State: AOJu0Yxxr8vYOd00QAYVSJcG0XXybTAJ1I7MlmDwtQ53ea6UyAmHOGl2 m0cYTnfakMXuxokKBrAhg1ttfwW1LhHzA41f1IJksR/1RIl1dP3zU8IjoJ41NUAIwOXFHGXEw4g cSu7B8B3Q29vJoU1/j51EM6ZjGLsEFtZ2dTIhST8hQ3KGMS0CVbNd3X5XBjTbOu9CeZYJaho= X-Gm-Gg: AfdE7ckm1SQNgkE4+G1xs8K32IkFAyDQITF7pbkez3xNarCcnlF/rxRpP4bwu4jUp9L 5sXLY8BmHIJ1FCfi2PB4/HYw1eRVmdDd28FnvytXpgL5YOCNbL8ddNVD0JSBgNQ9+KSXxVCIXOP BMIK9z5Jij3wYyW1uv5T0jSFUu1n3td8ihb8gN2yhfwc8KOb3BsE6sbpuK8MjQC8rEDJrmZ4Zae KStex+9VkXhr1c4lM7rGiMM4kPurQ5ou7l8nsQDtbmGqj/rqTXEsixopJch+lPCxh4NJDUaX8E8 8ajsAMHo0qwfgExvpEhJal2FnNgOQ5h3+SbwdKMj0i3+bDUjvbA6aBz+VY49fAKhUkibJtgdhTA PBO5lVzaCjz90NrFr9Bzs X-Received: by 2002:a05:6a20:548c:b0:3c0:29c6:20c5 with SMTP id adf61e73a8af0-3c08ef579fdmr7954882637.55.1783450457813; Tue, 07 Jul 2026 11:54:17 -0700 (PDT) X-Received: by 2002:a05:6a20:548c:b0:3c0:29c6:20c5 with SMTP id adf61e73a8af0-3c08ef579fdmr7954852637.55.1783450457365; Tue, 07 Jul 2026 11:54:17 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659c8572sm10944555c88.9.2026.07.07.11.54.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 11:54:16 -0700 (PDT) Message-ID: <0f8bd92f-7940-4faa-b5a8-7bd67f0a94f5@redhat.com> Date: Tue, 7 Jul 2026 15:54:13 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/record-full: make record_full_arch_list_add take an rvalue ref To: Simon Marchi , gdb-patches@sourceware.org References: <20260706164012.507674-1-simon.marchi@efficios.com> From: Guinevere Larsen In-Reply-To: <20260706164012.507674-1-simon.marchi@efficios.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: R2X8UbdZQSBT0b8P-A4AO_SwOmP7DanLU2xGwV_wCac_1783450458 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/6/26 1:40 PM, Simon Marchi wrote: > record_full_arch_list_add moves its `rec` argument, so it should take an > rvalue ref to reflect that. Otherwise the fact that the object is moved > from can be a "surprise" to the callers. > > Change-Id: Ibeb56b1523ad8aee077d3bc3cad1f00d6b47ea2f > --- Yeah, this makes sense, and feels pretty straightforward Approved-By: Guinevere Larsen > gdb/record-full.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gdb/record-full.c b/gdb/record-full.c > index 1392510a175c..aa451c05a5d9 100644 > --- a/gdb/record-full.c > +++ b/gdb/record-full.c > @@ -735,7 +735,7 @@ record_full_log_release_first (void) > /* Add a struct record_full_entry to record_full_arch_list. */ > > static void > -record_full_arch_list_add (record_full_entry &rec) > +record_full_arch_list_add (record_full_entry &&rec) > { > record_full_incomplete_instruction.effects.push_back (std::move (rec)); > } > @@ -758,7 +758,7 @@ record_full_arch_list_add_reg (struct regcache *regcache, int regnum) > if (regnum == gdbarch_pc_regnum (regcache->arch ())) > record_full_incomplete_instruction.pc = std::move (rec.reg ()); > else > - record_full_arch_list_add (rec); > + record_full_arch_list_add (std::move (rec)); > > return 0; > } > @@ -784,7 +784,7 @@ record_full_arch_list_add_mem (CORE_ADDR addr, int len) > rec.get_loc (), len)) > return -1; > > - record_full_arch_list_add (rec); > + record_full_arch_list_add (std::move (rec)); > > return 0; > } > @@ -2399,7 +2399,7 @@ record_full_entry::from_bfd (bfd *cbfd, asection *osec, int *bfd_offset) > bfd_get_filename (cbfd))); > break; > } > - record_full_arch_list_add (rec); > + record_full_arch_list_add (std::move (rec)); > } > > void > > base-commit: abcf25501f986df152581faeff08419c198a7ec3 -- Cheers, Guinevere Larsen it/its she/her (deprecated)