Re: [PATCH 00/13] Fix various warnings when building on macOS

[Simon Marchi <simon.marchi@efficios.com>]

On 8/17/26 11:16 AM, Simon Marchi wrote:
> I tried a build on macOS with the following configure flags (there is no
> native configuration for macOS/AArch64, so I used an alternative target
> to at least build the generic parts of GDB):
> 
>   --enable-targets=all --target=x86_64-pc-linux-gnu
> 
> This series fixes most of the build errors I encountered, mostly about
> the uses of "dangerous" functions like sprintf.
> 
> There one patch in opcodes, which will require the approval from a
> binutils maintainer.
> 
> There are 3 patches in sim, which will require the apprival from a sim
> maintainer.
> 
> The rest is in GDB, and I would of course appreciate some reviews for
> those too.
> 
> There are still some warnings about vfork being deprecated, like:
> 
>       CXX    cli/cli-cmds.o
>     /Users/smarchi/src/binutils-gdb/gdb/cli/cli-cmds.c:917:9: error: 'vfork' is deprecated: Use posix_spawn or fork [-Werror,-Wdeprecated-declarations]
>       917 |   pid = vfork ();
>           |         ^
> 
> I have not fixed those, as it requires more thought about the
> consequences of changing this on all supported platforms.

I pushed the patches that were Approved-By and that don't involve
xstrcpy, I will then work on addressing the comments on the rest.

Simon