From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id APjzHQ3/3F8NeQAAWB0awg (envelope-from ) for ; Fri, 18 Dec 2020 14:12:13 -0500 Received: by simark.ca (Postfix, from userid 112) id 755FC1F0AA; Fri, 18 Dec 2020 14:12:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C946D1E590 for ; Fri, 18 Dec 2020 14:12:12 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 240163857004; Fri, 18 Dec 2020 19:12:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 240163857004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608318732; bh=GDtZJVZKTnc15HQxPr47ca2Cf47+R7wFMUNQ2FReUMw=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wEFfjk2bOY6VFh3iaokGIhZKOs+egg61s33vXxtkavby00R+SgHUWUMc67WPxBMED vqr7Ws2x98tjs0+3Qu/50uu7ZOjxfCFO1cQG04H6hsKm8GwP4/WQCJLyWBkObDuTYV pHs1bcVFkh3u1weIR1Z0L9GEUhg625IMND3Rm41o= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 1520F3857004 for ; Fri, 18 Dec 2020 19:12:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1520F3857004 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BIJC3Tq012849 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Dec 2020 14:12:08 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BIJC3Tq012849 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7736D1E590; Fri, 18 Dec 2020 14:12:03 -0500 (EST) Subject: Re: [PATCH] gdb: define COFF file offsets with file_ptr To: Simon Marchi , Jameson Nash References: <20201126181121.31219-1-vtjnash@gmail.com> <2bb948a7-e909-8949-7486-2aec0c4a9ecf@simark.ca> <271c1246-2c36-accc-b1c7-3340a71993fb@simark.ca> Message-ID: <0f582b65-f198-9002-eb33-6cd8a7c44afc@polymtl.ca> Date: Fri, 18 Dec 2020 14:12:03 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <271c1246-2c36-accc-b1c7-3340a71993fb@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 18 Dec 2020 19:12:03 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-27 3:55 p.m., Simon Marchi wrote: > On 2020-11-27 3:49 p.m., Jameson Nash wrote: >> It's (currently) computed as the difference of two file_ptr values. The result should be positive, certainly, as it's later used as either a file offset (with a printed warning) and as a size_t. But I'm more inclined to keep it common with the other values here, and use `file_ptr`, which is a signed integer type like `off_t` and `ssize_t`. > > Ok, that's fine with me. > > Simon > I have now pushed this patch. Simon