From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116928 invoked by alias); 14 Jan 2020 13:31:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116910 invoked by uid 89); 14 Jan 2020 13:31:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Spam-Relays-External:209.85.222.194, H*RU:209.85.222.194, indication X-HELO: mail-qk1-f194.google.com Received: from mail-qk1-f194.google.com (HELO mail-qk1-f194.google.com) (209.85.222.194) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Jan 2020 13:30:42 +0000 Received: by mail-qk1-f194.google.com with SMTP id w127so12010219qkb.11 for ; Tue, 14 Jan 2020 05:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+H6TAirxNeR1vGpYP8jO5ZuXIY6qgObId48pZMrf+zw=; b=L56dXGPJ97hCndPZ5bhzV+SbnT3NVVSHLxwB0PZnRg+ne/1RPN1eusMHyjbHjpvc8F 5Ro1GcA1gjNzpjs5ZTI3O+qjegER7XAEZiEjeNuSouo6ux8sV/JXphIBtZbfolXEryBD qLJqqGz7wczArYsmqDepXgu2RAexnO0Js595wEog+GmAt3HaQDkMCGIG4OlTsm2E2GHP Fu6cCh2hPGfX7qY43+zAEcA+mQLm3r/Vmw2e15/64x33ibEcNVElzHuncoEKZlQWwj6f oyA7jpGg7Eo0f4fJcgPhbj2bR1aWecAhkszLut+hRDw1Fw/SX3yQqVBR1vfqNRzjxA3N F+kg== Return-Path: Received: from [192.168.0.185] ([179.177.239.131]) by smtp.gmail.com with ESMTPSA id 3sm7456485qte.59.2020.01.14.05.30.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2020 05:30:20 -0800 (PST) Subject: Re: [PATCH 2/2][AArch64] Test handling of additional brk instruction patterns To: Simon Marchi , gdb-patches@sourceware.org Cc: alan.hayward@arm.com, tankut.baris.aktemur@intel.com References: <20200113172524.7201-1-luis.machado@linaro.org> <20200113172524.7201-3-luis.machado@linaro.org> From: Luis Machado Message-ID: <0f4a6a0a-540b-7641-cd3e-2fef07cf3994@linaro.org> Date: Tue, 14 Jan 2020 13:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00371.txt.bz2 On 1/14/20 1:25 AM, Simon Marchi wrote: > On 2020-01-13 12:25 p.m., Luis Machado wrote: >> This test exercises the previous patch's code and makes sure GDB can >> properly get a SIGTRAP from various brk instruction patterns. >> >> GDB needs to be able to see the program exiting normally. If GDB doesn't >> support the additional brk instructions, we will see timeouts. >> >> We bail out with the first timeout since we won't be able to step through >> the program breakpoint anyway, so it is no use carrying on. >> >> gdb/testsuite/ChangeLog: >> >> 2020-01-13 Luis Machado >> >> * gdb.arch/aarch64-brk-patterns.c: New source file. >> * gdb.arch/aarch64-brk-patterns.exp: New test. >> --- >> gdb/testsuite/gdb.arch/aarch64-brk-patterns.c | 30 +++++++++ >> .../gdb.arch/aarch64-brk-patterns.exp | 67 +++++++++++++++++++ >> 2 files changed, 97 insertions(+) >> create mode 100644 gdb/testsuite/gdb.arch/aarch64-brk-patterns.c >> create mode 100644 gdb/testsuite/gdb.arch/aarch64-brk-patterns.exp >> >> diff --git a/gdb/testsuite/gdb.arch/aarch64-brk-patterns.c b/gdb/testsuite/gdb.arch/aarch64-brk-patterns.c >> new file mode 100644 >> index 0000000000..ccf9a35a94 >> --- /dev/null >> +++ b/gdb/testsuite/gdb.arch/aarch64-brk-patterns.c >> @@ -0,0 +1,30 @@ >> +/* This file is part of GDB, the GNU debugger. >> + >> + Copyright 2020 Free Software Foundation, Inc. >> + >> + This program is free software; you can redistribute it and/or modify >> + it under the terms of the GNU General Public License as published by >> + the Free Software Foundation; either version 3 of the License, or >> + (at your option) any later version. >> + >> + This program is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + GNU General Public License for more details. >> + >> + You should have received a copy of the GNU General Public License >> + along with this program. If not, see . */ >> + >> +int main(void) >> +{ >> + /* Dummy instruction just so GDB doesn't stop at the first breakpoint >> + instruction. */ >> + __asm __volatile ("nop\n\t"); >> + >> + /* Multiple BRK instruction patterns. */ >> + __asm __volatile ("brk %0\n\t" ::"n"(0x0)); >> + __asm __volatile ("brk %0\n\t" ::"n"(0x900 + 0xf)); >> + __asm __volatile ("brk %0\n\t" ::"n"(0xf000)); >> + >> + return 0; >> +} >> diff --git a/gdb/testsuite/gdb.arch/aarch64-brk-patterns.exp b/gdb/testsuite/gdb.arch/aarch64-brk-patterns.exp >> new file mode 100644 >> index 0000000000..3532a0df95 >> --- /dev/null >> +++ b/gdb/testsuite/gdb.arch/aarch64-brk-patterns.exp >> @@ -0,0 +1,67 @@ >> +# Copyright 2020 Free Software Foundation, Inc. >> +# >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 3 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program. If not, see . >> +# >> +# This file is part of the gdb testsuite. >> + >> +# Test if GDB stops at various BRK instruction patterns inserted into >> +# the code. >> + >> +if {![is_aarch64_target]} { >> + verbose "Skipping ${gdb_test_file_name}." >> + return >> +} >> + >> +standard_testfile >> +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { >> + return -1 >> +} >> + >> +if ![runto_main] { >> + untested "could not run to main" >> + return -1 >> +} >> + >> +set keep_going 1 >> +set count 0 >> +set old_timeout $timeout >> +set timeout 10 >> + >> +while { $keep_going } { >> + >> + set test "brk instruction $count causes SIGTRAP" >> + >> + # Continue to next program breakpoint instruction. >> + gdb_test_multiple "continue" $test { >> + -re "Program received signal SIGTRAP, Trace/breakpoint trap.*$gdb_prompt $" { >> + pass $test >> + >> + # Insert a breakpoint at the program breakpoint instruction so GDB >> + # can step over it. >> + gdb_test "break" \ >> + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ >> + "insert breakpoint at brk instruction $count" >> + } >> + -re "exited normally.*$gdb_prompt $" { >> + set keep_going 0 >> + } >> + timeout { >> + fail $test >> + set keep_going 0 >> + } >> + } >> + set count [expr "$count + 1"] >> +} >> + >> +set timeout $old_timeout >> -- >> 2.17.1 >> > > I don't see anything wrong with the test, but I was wondering if we should > assert that $count is the right value in the end, to make sure that we did > hit the expected number of breakpoints. > > Simon > The idea behind the test is that GDB will get a SIGTRAP and be able to step over all of the program breakpoints until the inferior exits. We don't count how many of those breakpoints we've hit. If GDB gets stuck during "continue" and doesn't hit one of the breakpoints, then we throw a fail. That failure is an indication that something is wrong. If someone wants to add more breakpoint patterns to the test, the .exp file won't need to be changed. Does that make sense? Or do you think it would be better to have a fixed set of instruction the test is bound to?